Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use duration for plan phases instead of start after #1954

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: use duration for plan phases instead of start after #1954

wants to merge 1 commit into from

Conversation

tothandras
Copy link
Contributor

TODO:

  • type mappings
  • validations
  • remove phase level APIs

hekike
hekike reviewed Dec 10, 2024
View reviewed changes
openmeter/ent/schema/productcatalog.go
@@ -38,6 +37,7 @@ func (Plan) Fields() []ent.Field {
field.Time("effective_to").
Optional().
Nillable(),
field.Strings("phase_order"),
Copy link
Contributor

@hekike hekike Dec 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UInt that's unique with phase id?

Copy link
Contributor Author

@tothandras tothandras Dec 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's an array of the the keys of the phases on the plan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hekike hekike hekike left review comments

@chrisgacsal chrisgacsal Awaiting requested review from chrisgacsal

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tothandras @hekike