-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) O3-4160: Patient header redesign #1195
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -133 kB (-2.12%) Total Size: 6.13 MB
ℹ️ View Unchanged
|
Design discussion with @ciaranduffy here https://openmrs.slack.com/archives/CKS32D55G/p1730111565689469 |
ibacher
reviewed
Nov 4, 2024
packages/framework/esm-styleguide/src/patient-banner/patient-info/gender-icons.component.tsx
Outdated
Show resolved
Hide resolved
...-styleguide/src/patient-banner/patient-info/patient-banner-patient-identifiers.component.tsx
Outdated
Show resolved
Hide resolved
...-styleguide/src/patient-banner/patient-info/patient-banner-patient-identifiers.component.tsx
Outdated
Show resolved
Hide resolved
...-styleguide/src/patient-banner/patient-info/patient-banner-patient-identifiers.component.tsx
Outdated
Show resolved
Hide resolved
...ork/esm-styleguide/src/patient-banner/patient-info/patient-banner-patient-info.component.tsx
Outdated
Show resolved
Hide resolved
...ork/esm-styleguide/src/patient-banner/patient-info/patient-banner-patient-info.component.tsx
Outdated
Show resolved
Hide resolved
...ework/esm-styleguide/src/patient-banner/patient-info/patient-banner-patient-info.module.scss
Outdated
Show resolved
Hide resolved
denniskigen
force-pushed
the
patient-header-redesign
branch
from
November 5, 2024 10:44
48900ee
to
f7fd299
Compare
chibongho
reviewed
Nov 5, 2024
...-styleguide/src/patient-banner/patient-info/patient-banner-patient-identifiers.component.tsx
Outdated
Show resolved
Hide resolved
...ork/esm-styleguide/src/patient-banner/patient-info/patient-banner-patient-info.component.tsx
Show resolved
Hide resolved
denniskigen
force-pushed
the
patient-header-redesign
branch
from
November 6, 2024 19:32
f7fd299
to
c226178
Compare
denniskigen
force-pushed
the
patient-header-redesign
branch
from
November 6, 2024 19:43
c226178
to
3d6ec39
Compare
ibacher
approved these changes
Nov 7, 2024
Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
feat
,fix
, orchore
, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
This PR introduces the first iteration of changes to align the Patient Header with the new designs. Specifically, this PR does the following:
Show / hide details
buttons to readShow more
andShow less
to match the designs.Screenshots
current-state-of-things.mp4
Related Issue
https://issues.openmrs.org/browse/O3-4160
Other