(feat) OA-41: openmrsFetch() should handle redirects #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -85.8 kB (-1.37%) Total Size: 6.16 MB
ℹ️ View Unchanged
|
|
This is a great addition @ibacher because it will also automatically address one of the requirements for https://openmrs.atlassian.net/browse/OA-37, i.e. redirect the user to the IDP upon logout when the oauth2 module sets the location header in the response, when do you intend to move this PR out of the draft state? |
|
Basically, once I'm able to test that it works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
feat,fix, orchore, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
This implements a simple protocol for the backend to be able to send redirect responses to the frontend.
Normally, redirect responses are handled by a HTTP response in the 300-399 range, with a
Locationheader indicating where the page should redirect to. The problem is how this is handled withfetch()requests. Specifically, while using thefetch()API, 3xx responses cause the fetch request itself to redirect to the new URL, meaning that the user's UI doesn't change at all. For SPAs, this is usually the desired behaviour, since SPAs will usually do the work on the frontend.Instead, this hijacks the meaning of a 204 ("No Content") response from the backend. If the response is a 204 and there's a
Locationheader and this feature hasn't been turned off via config, thenopenmrsFetch()will redirect to the URL specified in the header. This gives us a small escape hatch so the backend can redirect the browser to a specific page.Screenshots
Related Issue
Other