(feat) Age should be represented in internationalized translated way #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -674 kB (-19%) 👏 Total Size: 2.79 MB
ℹ️ View Unchanged
|
ibacher
requested changes
Sep 12, 2023
There was a problem hiding this comment.
We can't accept this as-is, I think. It's common to refer to ages under 2 years (and sometimes three) by months, that is "18 months" rather than "1 year 6 months", even though these refer to the same period of time. If we want to make that English-specific, I'd accept it with the endorsement of a non-English-speaking pediatrician, but absent that, we should maintain the same output as is already here.
Also, it would be best if we didn't do all of the calculations of every possible string every time, but only when they were relevant.
ibacher
reviewed
Sep 27, 2023
| @@ -67,24 +67,64 @@ export function age(dateString: string): string { | |||
| // The "remainder" number of days after the weeksAgo number of weeks | |||
| const remainderDaysInWeek = totalDaysAgo - weeksAgo * 7; | |||
|
|
|||
| const rtf = new Intl.RelativeTimeFormat(getLocale(), { numeric: "auto" }); | |||
|
|
|||
| const totalDaysAgoStr = | |||
There was a problem hiding this comment.
Sorry, a couple more small things:
- Can we reduce the
getLocale()calls to a single call? - It would be nice if we only calculated the strings we're actually using instead of all of them every time.
- For weeks ago, I'd probably leave of the "days". Although this is relevant, I'm worried that the word order isn't always going to render properly, e.g., for Hebrew and Arabic, and we can fix that later.
|
Hi @ibacher ! |
ibacher
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
For changes to apps
If applicable
Summary
The age function currently returns the age in english strings, i.e. "4 years", "4 weeks". The age function will now return the age according to the locale of the application.
Screenshots
Infant born on the same day
Infant smaller than 1 month
Infant less than 1 year
Child less than 2 years
Age in years
Related Issue
Other