(feat) Load pure CSS files in the styleguide via css-loader
#777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -921 kB (-25%) 🎉 Total Size: 2.79 MB
ℹ️ View Unchanged
|
denniskigen
changed the title
css-loader
ibacher
approved these changes
Oct 3, 2023
|
Have you tested this with the updated React Spectrum libraries? |
|
So, I think this also needs to be applied to the framework. |
mseaton
reviewed
Oct 3, 2023
| use: [{ loader: MiniCssExtractPlugin.loader }, "css-loader"], | ||
| }, | ||
| { | ||
| test: /\.s[ac]ss$/i, |
There was a problem hiding this comment.
What is the "postcss-loader" used for sass/scss, and is this needed for pure css?
There was a problem hiding this comment.
It runs postcss, a CSS post-processor on the CSS. I suppose it wouldn't hurt to put in here. (we mostly use it for this feature).
|
Closing in favour of #778 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
For changes to apps
If applicable
Summary
This PR attempts to fix an issue where the latest version of the openmrs tooling fails to build frontend assets as expected. More specifically, running
npx --legacy-peer-deps openmrs@next build --build-config /spa-build-config.json --target /app(or its equivalents) yields the following error:https://openmrs.slack.com/files/UJ8TY7J05/F05UG139EHM/cleanshot_2023-10-03_at_12___.10.08_2x.png?origin_team=T03U4PGDY&origin_channel=CHP5QAE5R
Digging deeper, this error stems from the tooling failing to load CSS provided by the React Spectrum library. As explained in the linked thread, the styleguide uses a custom webpack config which doesn't leverage either
style-loaderorcss-loaderfor loading CSS modules. This PR adds a rule to the styleguide's webpack config that enables loading pure CSS files (such as the ones coming from external libraries) usingcss-loader.Screenshots
Related Issue
Other