(feat) O3-2583: Configure Password Field Placement on Login Screen #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Configuration Variable: - Introduced a new configuration variable named 'passwordOnSeparateScreen' to allow implementers to customize the placement of the password field on the login screen. - The default value is set to 'true' to maintain the existing behavior of having the password field on a separate screen. Configuration Usage: - When 'passwordOnSeparateScreen' is set to 'true', the password field appears on a separate screen. - When set to 'false', the password field is displayed on the same screen as the username and other login elements.
jayasanka-sack
commented
Nov 21, 2023
ibacher
reviewed
Nov 21, 2023
There was a problem hiding this comment.
Thanks @jayasanka-sack! Some comments. Also, please include a conventional commit message in your PR title at least.
jayasanka-sack
changed the title
denniskigen
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Largely looks good to me, save for a few concerns about naming. Thanks, @jayasanka-sack.
denniskigen
approved these changes
Dec 7, 2023
denniskigen
reviewed
Dec 7, 2023
| @@ -247,4 +247,64 @@ describe("Login", () => { | |||
| expect(performLogin).toHaveBeenCalledWith("yoshi", "no-tax-fraud") | |||
| ); | |||
| }); | |||
|
|
|||
| it("should focus the username input", async () => { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
For changes to apps
If applicable
Summary
This pull request addresses the enhancement outlined in the "Configure Password Field Placement on Login Screen (O3-2583)" ticket under the "Enhance Login Page Configurability" epic.
Changes Introduced:
New Configuration Variable:
Configuration Usage:
Other
Other Changes I've done:
mockConfigdidn't use the correct type and there were some missing fields, I've fixed itScreenshots
Related Issue
https://issues.openmrs.org/browse/O3-2583