-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(chore) Removed icon button overrides from the esm-styleguide #850
Conversation
Size Change: -4 B (0%) Total Size: 2.71 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Important to note that the layout constraint override particularly affected button variants of size sm
. It appeared to me at the time I introduced the override that the sm
prop didn't take. Something to note while testing these changes out. If you find that the issue persists, it'll likely be owing to layout constraint overrides.
Requirements
feat
,fix
, orchore
, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
Removes the icon button overrides from esm-styleguide.
Screenshots
None
Related Issue
None
Other
Related PR: openmrs/openmrs-esm-patient-chart#1541