(chore) Bump testing dependencies and fix test console warnings #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniskigen
requested review from
vasharma05,
ibacher,
brandones and
jayasanka-sack
|
Size Change: -378 kB (-12%) 👏 Total Size: 2.71 MB
ℹ️ View Unchanged
|
vasharma05
reviewed
Dec 19, 2023
| @@ -205,7 +206,8 @@ describe('Configuration', () => { | |||
|
|
|||
| renderConfiguration(); | |||
|
|
|||
| const rowElement = (await screen.findByText('numberFingers')).closest('.cds--structured-list-row'); | |||
| screen.findByText('numberFingers'); | |||
There was a problem hiding this comment.
Shouldn't we have an await before findBy*?
vasharma05
approved these changes
Dec 19, 2023
| }); | ||
|
|
||
| it('should redirect to login if the application is Offline', async () => { | ||
| (useConnectivity as jest.Mock).mockReturnValue(false); | ||
| render(<RedirectLogout />); | ||
| expect(navigate).toBeCalledWith({ to: '${openmrsSpaBase}/login' }); | ||
| expect(navigate).toHaveBeenCalledWith({ to: '${openmrsSpaBase}/login' }); |
There was a problem hiding this comment.
https://jestjs.io/docs/expect#tohavebeencalled
Since these 2 are an alias to one another, we might skip these changes, until I'm missing something. If I am, please correct me.
Thanks!
There was a problem hiding this comment.
toBeCalledWith was deprecated.
|
Thanks @denniskigen for the awesome bumps and cleanups! 🚀 |
| @@ -27,14 +27,14 @@ | |||
| "coverage": "yarn test --coverage" | |||
| }, | |||
| "devDependencies": { | |||
| "@jest/types": "^29.6.3", | |||
| "@playwright/test": "1.39.0", | |||
| "@playwright/test": "1.40.1", | |||
There was a problem hiding this comment.
This docker file also should be updated when bumping playwright:
https://github.com/openmrs/openmrs-esm-core/blob/main/e2e/support/bamboo/playwright.Dockerfile#L1
There was a problem hiding this comment.
Cool, could you please handle that?
brandones
reviewed
Jan 9, 2024
|
|
||
| render(<App />); | ||
| }); | ||
| await act(async () => await promise); |
There was a problem hiding this comment.
@denniskigen What's this do?
There was a problem hiding this comment.
It creates a promise and waits for it to resolve. Waiting for the mocked promise simulates waiting for the asynchronous operation to complete. It's discussed here, among other approaches for fixing the 'not wrapped in act' warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
feat,fix, orchore, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
I've bumped testing dependencies (
@playwright/test,@testing-library/dom,@testing-library/jest-dom,@testing-library/react,@testing-library/user-eventand typings for jest) to the latest versions. I've also fixed various warnings and errors in the test console output and replaced usages offireEventwithuserEvent.Screenshots
test-console-output-before.mp4
test-console-output.mp4
Related Issue
Other