Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) O3-2734: Fix user menu tooltip and toast notification description #880

Merged

Conversation

usamaidrsk
Copy link
Member

@usamaidrsk usamaidrsk commented Jan 11, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. Ensure your PR title includes a conventional commit label (such as feat, fix, or chore, among others). See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

  • Fix user menu naming from user dashboard in the snack bar notification on location preference change, as well as the aria-label on the User menu from Users to User

Screenshots

image
image

Related Issue

O3-2734

Other

@usamaidrsk usamaidrsk changed the title (fix) O3-2734: Fix user menu arial label and user menu naming on the snackbar (fix) O3-2734: Fix user menu tooltip and toast notification description Jan 11, 2024
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @usamaidrsk!

@denniskigen denniskigen merged commit 6f89ecc into openmrs:main Jan 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants