(feat) Add 'ward-patient' group to the order basket related workspaces #2130
+121
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @brandones @ibacher @chibongho, |
vasharma05
force-pushed
the
feat/add-order-basket-to-ward
branch
from
b019a98 to
603732f
Compare
|
Size Change: -38.8 kB (-0.24%) Total Size: 16 MB
ℹ️ View Unchanged
|
|
Any reason why the build job is failing during the Thanks! |
No So, solution-wise, I don't think what we're doing in this PR is sustainable. We need a way of the ward app to be able to declare that these are the workspaces that it's using. This suggests to me that we need to reconsider being able to set the group during the call to launch workspace or some other mechanism that doesn't require modifying the workspace registration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR adds the necessary changes to add the order basket to the ward app:
ward-patientgroup name to the order basket related workspaces registrationScreenshots
Screen.Recording.2024-12-12.at.17.46.54.mov
Related Issue
None
Other
Depends on openmrs/openmrs-esm-core#1185