(fix) Fix react hooks exhaustive deps warnings

This PR fixes exhaustive deps warnings for React hooks flagged by the React hooks ESLint plugin.
openmrs · Nov 21, 2024 · c5e257b · c5e257b
1 parent b2bf704
commit c5e257b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -11,8 +11,6 @@
   "parser": "@typescript-eslint/parser",
   "plugins": ["@typescript-eslint", "import", "jest-dom", "react-hooks", "testing-library"],
   "rules": {
-    "react-hooks/rules-of-hooks": "error",
-    "react-hooks/exhaustive-deps": "warn",
     // Disabling these rules for now just to keep the diff small. We'll enable them one by one as we go.
     "@typescript-eslint/ban-ts-comment": "off",
     "@typescript-eslint/ban-types": "off",
@@ -33,7 +31,6 @@
       }
     ],
     "import/no-duplicates": "error",
-    "prefer-const": "off",
     "no-console": [
       "error",
       {
@@ -70,7 +67,10 @@
           }
         ]
       }
-    ]
+    ],
+    "prefer-const": "off",
+    "react-hooks/rules-of-hooks": "error",
+    "react-hooks/exhaustive-deps": "warn"
   },
   "overrides": [
     {

diff --git a/packages/esm-service-queues-app/src/patient-queue-header/patient-queue-header.component.tsx b/packages/esm-service-queues-app/src/patient-queue-header/patient-queue-header.component.tsx
@@ -59,11 +59,13 @@ const PatientQueueHeader: React.FC<PatientQueueHeaderProps> = ({ title, showLoca
       }
     }
   }, [
-    queueLocations,
     currentQueueLocationName,
     currentQueueLocationUuid,
-    isLoading,
     error,
+    handleQueueLocationChange,
+    isLoading,
+    queueLocations,
+    userSession?.sessionLocation?.display,
     userSession?.sessionLocation?.uuid,
     handleQueueLocationChange,
     userSession?.sessionLocation?.display,