-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) O3-4011 - Ward App - make styling for patient card's patient id… #1321
Conversation
Size Change: +187 B (0%) Total Size: 6.46 MB ℹ️ View Unchanged
|
I ended up changing the implementation so that the patient identifier is rendered from a New changes depends on this PR: Converted this one to draft since the yarn.lock file depends on local changes not changed into esm-core yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me (assuming we resolve the local lock stuff first)
…entifier consistent
Requirements
Summary
Styling of the patient identifier in the patient card's header row vs the mother child row were inconsistent. This PR fixes it.
I ended up having to change the mother-child row to not hard-code the elements (and instead define them in config) so that the same element config can be used in both the header row and mother -child row.
I also made it so that if the label for the patient identifier type is empty, we display the patient identifier (instead of the patient identifier type) in a carbon Tag. This should make the identifier fairly prominent and easy to find.
Screenshots
Before:
After:
Related Issue
Other