-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) O3-4180: Configure Advanced search filter to support person attributes #1362
Conversation
Size Change: -38 kB (-0.52%) Total Size: 7.22 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few changes/ updates needed. If you can, move the form handling to RHF, rather than reducer based updation, for better validations and handling.
packages/esm-patient-search-app/src/patient-search-page/advanced-patient-search.component.tsx
Outdated
Show resolved
Hide resolved
...atient-search-app/src/patient-search-page/refine-search/person-attribute-field.component.tsx
Outdated
Show resolved
Hide resolved
...s/esm-patient-search-app/src/patient-search-page/refine-search/person-attributes.resource.ts
Outdated
Show resolved
Hide resolved
...s/esm-patient-search-app/src/patient-search-page/refine-search/person-attributes.resource.ts
Outdated
Show resolved
Hide resolved
...-patient-search-app/src/patient-search-page/refine-search/refine-search-tablet.component.tsx
Outdated
Show resolved
Hide resolved
...-patient-search-app/src/patient-search-page/refine-search/refine-search-tablet.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-search-app/src/patient-search-page/refine-search/tsconfig.json
Outdated
Show resolved
Hide resolved
_type: Type.UUID, | ||
_description: 'Answer concept UUID', | ||
}, | ||
label: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not allow passing labels, it's another hassle to handle the translations, the labels should be used from the backend.
packages/esm-patient-search-app/src/patient-search-page/advanced-patient-search.component.tsx
Outdated
Show resolved
Hide resolved
...atient-search-app/src/patient-search-page/refine-search/person-attribute-field.component.tsx
Outdated
Show resolved
Hide resolved
...atient-search-app/src/patient-search-page/refine-search/person-attribute-field.component.tsx
Outdated
Show resolved
Hide resolved
...s/esm-patient-search-app/src/patient-search-page/refine-search/person-attributes.resource.ts
Outdated
Show resolved
Hide resolved
...-patient-search-app/src/patient-search-page/refine-search/refine-search-tablet.component.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Vineet Sharma <[email protected]>
Requirements
Summary
This PR enhances the patient search functionality by adding support for advanced filtering based on person attributes. It now enables filtering by multiple attribute types, including strings, concepts, and locations, for more refined and comprehensive search results. Additionally, this update introduces configuration to enable or disable specific fields such as date of birth, postal code, gender, and age, allowing for greater flexibility in search customization.
Testing Config
Screenshots
configure-attributes-on-advanced-patient-search.mp4
Related Issue
https://openmrs.atlassian.net/browse/O3-4180
Other