Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) O3-4180: Configure Advanced search filter to support person attributes #1362

Merged
merged 22 commits into from
Dec 6, 2024

Conversation

usamaidrsk
Copy link
Member

@usamaidrsk usamaidrsk commented Nov 7, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR enhances the patient search functionality by adding support for advanced filtering based on person attributes. It now enables filtering by multiple attribute types, including strings, concepts, and locations, for more refined and comprehensive search results. Additionally, this update introduces configuration to enable or disable specific fields such as date of birth, postal code, gender, and age, allowing for greater flexibility in search customization.

Testing Config

{
  "@openmrs/esm-patient-search-app": {
    "search": {
      "patientChartUrl": "${openmrsSpaBase}/patient/${patientUuid}/chart/",
      "showRecentlySearchedPatients": true,
      "disableTabletSearchOnKeyUp": false,
      "searchFields": {
        "fields": {
          "gender": {
            "enabled": true
          },
          "dateOfBirth": {
            "enabled": true
          },
          "age": {
            "enabled": true
          },
          "postcode": {
            "enabled": true
          }
        },
        "personAttributes": [
          {
            "attributeTypeUuid": "14d4f066-15f5-102d-96e4-000c29c2a5d7"
          },
          {
            "attributeTypeUuid": "8d87236c-c2cc-11de-8d13-0010c6dffd0f"
          }
        ]
      }
    },
    "includeDead": true,
    "contactAttributeType": [
      "14d4f066-15f5-102d-96e4-000c29c2a5d7",
      "e3d177ee-04ad-11ed-828d-0242ac1e0002"
    ],
    "defaultIdentifierTypes": [
      "05a29f94-c0ed-11e2-94be-8c13b969e334"
    ]
  }
}

Screenshots

image

configure-attributes-on-advanced-patient-search.mp4

Related Issue

https://openmrs.atlassian.net/browse/O3-4180

Other

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Size Change: -38 kB (-0.52%)

Total Size: 7.22 MB

Filename Size Change
packages/esm-patient-search-app/dist/743.js 0 B -78.7 kB (removed) 🏆
packages/esm-patient-search-app/dist/main.js 167 kB +33.3 kB (+24.8%) 🚨
ℹ️ View Unchanged
Filename Size Change
packages/esm-active-visits-app/dist/106.js 8.63 kB 0 B
packages/esm-active-visits-app/dist/130.js 394 kB 0 B
packages/esm-active-visits-app/dist/136.js 65.6 kB 0 B
packages/esm-active-visits-app/dist/233.js 3.37 kB 0 B
packages/esm-active-visits-app/dist/236.js 614 B 0 B
packages/esm-active-visits-app/dist/240.js 615 B 0 B
packages/esm-active-visits-app/dist/261.js 615 B 0 B
packages/esm-active-visits-app/dist/271.js 805 B 0 B
packages/esm-active-visits-app/dist/272.js 615 B 0 B
packages/esm-active-visits-app/dist/316.js 42.9 kB 0 B
packages/esm-active-visits-app/dist/319.js 735 B 0 B
packages/esm-active-visits-app/dist/325.js 3.09 kB 0 B
packages/esm-active-visits-app/dist/336.js 614 B 0 B
packages/esm-active-visits-app/dist/378.js 731 B 0 B
packages/esm-active-visits-app/dist/443.js 6.98 kB 0 B
packages/esm-active-visits-app/dist/460.js 817 B 0 B
packages/esm-active-visits-app/dist/539.js 613 B 0 B
packages/esm-active-visits-app/dist/574.js 615 B 0 B
packages/esm-active-visits-app/dist/6.js 28 kB 0 B
packages/esm-active-visits-app/dist/644.js 800 B 0 B
packages/esm-active-visits-app/dist/652.js 615 B 0 B
packages/esm-active-visits-app/dist/673.js 615 B 0 B
packages/esm-active-visits-app/dist/705.js 615 B 0 B
packages/esm-active-visits-app/dist/711.js 615 B 0 B
packages/esm-active-visits-app/dist/725.js 647 B 0 B
packages/esm-active-visits-app/dist/727.js 615 B 0 B
packages/esm-active-visits-app/dist/737.js 615 B 0 B
packages/esm-active-visits-app/dist/744.js 843 B 0 B
packages/esm-active-visits-app/dist/757.js 731 B 0 B
packages/esm-active-visits-app/dist/784.js 2.63 kB 0 B
packages/esm-active-visits-app/dist/788.js 628 B 0 B
packages/esm-active-visits-app/dist/807.js 959 B 0 B
packages/esm-active-visits-app/dist/814.js 3.04 kB 0 B
packages/esm-active-visits-app/dist/833.js 765 B 0 B
packages/esm-active-visits-app/dist/879.js 3.02 kB 0 B
packages/esm-active-visits-app/dist/899.js 611 B 0 B
packages/esm-active-visits-app/dist/967.js 611 B 0 B
packages/esm-active-visits-app/dist/main.js 96 kB 0 B
packages/esm-active-visits-app/dist/openmrs-esm-active-visits-app.js 3.5 kB 0 B
packages/esm-appointments-app/dist/111.js 10.6 kB 0 B
packages/esm-appointments-app/dist/123.js 272 kB 0 B
packages/esm-appointments-app/dist/130.js 394 kB 0 B
packages/esm-appointments-app/dist/139.js 35.6 kB 0 B
packages/esm-appointments-app/dist/171.js 223 B 0 B
packages/esm-appointments-app/dist/2.js 2.23 kB 0 B
packages/esm-appointments-app/dist/228.js 2.02 kB 0 B
packages/esm-appointments-app/dist/236.js 2.01 kB 0 B
packages/esm-appointments-app/dist/240.js 2.02 kB 0 B
packages/esm-appointments-app/dist/261.js 2.01 kB 0 B
packages/esm-appointments-app/dist/265.js 1.79 kB 0 B
packages/esm-appointments-app/dist/269.js 7.38 kB 0 B
packages/esm-appointments-app/dist/271.js 2.4 kB 0 B
packages/esm-appointments-app/dist/272.js 2.01 kB 0 B
packages/esm-appointments-app/dist/319.js 2.27 kB 0 B
packages/esm-appointments-app/dist/325.js 3.08 kB 0 B
packages/esm-appointments-app/dist/336.js 2.01 kB 0 B
packages/esm-appointments-app/dist/372.js 2.57 kB 0 B
packages/esm-appointments-app/dist/378.js 2.26 kB 0 B
packages/esm-appointments-app/dist/443.js 6.97 kB 0 B
packages/esm-appointments-app/dist/460.js 2.44 kB 0 B
packages/esm-appointments-app/dist/539.js 2.01 kB 0 B
packages/esm-appointments-app/dist/574.js 2.02 kB 0 B
packages/esm-appointments-app/dist/581.js 9.03 kB 0 B
packages/esm-appointments-app/dist/591.js 16.8 kB 0 B
packages/esm-appointments-app/dist/644.js 2.4 kB 0 B
packages/esm-appointments-app/dist/652.js 2.02 kB 0 B
packages/esm-appointments-app/dist/673.js 2.02 kB 0 B
packages/esm-appointments-app/dist/705.js 2.02 kB 0 B
packages/esm-appointments-app/dist/711.js 129 kB 0 B
packages/esm-appointments-app/dist/727.js 2.01 kB 0 B
packages/esm-appointments-app/dist/737.js 2.01 kB 0 B
packages/esm-appointments-app/dist/744.js 2.53 kB 0 B
packages/esm-appointments-app/dist/757.js 2.39 kB 0 B
packages/esm-appointments-app/dist/784.js 2.62 kB 0 B
packages/esm-appointments-app/dist/788.js 2.01 kB 0 B
packages/esm-appointments-app/dist/807.js 2.64 kB 0 B
packages/esm-appointments-app/dist/833.js 2.32 kB 0 B
packages/esm-appointments-app/dist/899.js 2.01 kB 0 B
packages/esm-appointments-app/dist/903.js 864 B 0 B
packages/esm-appointments-app/dist/main.js 413 kB 0 B
packages/esm-appointments-app/dist/openmrs-esm-appointments-app.js 3.56 kB 0 B
packages/esm-bed-management-app/dist/130.js 394 kB 0 B
packages/esm-bed-management-app/dist/148.js 1.37 kB 0 B
packages/esm-bed-management-app/dist/205.js 50.7 kB 0 B
packages/esm-bed-management-app/dist/236.js 793 B 0 B
packages/esm-bed-management-app/dist/240.js 793 B 0 B
packages/esm-bed-management-app/dist/261.js 794 B 0 B
packages/esm-bed-management-app/dist/271.js 793 B 0 B
packages/esm-bed-management-app/dist/272.js 794 B 0 B
packages/esm-bed-management-app/dist/319.js 908 B 0 B
packages/esm-bed-management-app/dist/325.js 3.09 kB 0 B
packages/esm-bed-management-app/dist/336.js 794 B 0 B
packages/esm-bed-management-app/dist/378.js 937 B 0 B
packages/esm-bed-management-app/dist/443.js 6.97 kB 0 B
packages/esm-bed-management-app/dist/460.js 892 B 0 B
packages/esm-bed-management-app/dist/539.js 793 B 0 B
packages/esm-bed-management-app/dist/542.js 396 B 0 B
packages/esm-bed-management-app/dist/574.js 794 B 0 B
packages/esm-bed-management-app/dist/591.js 16.8 kB 0 B
packages/esm-bed-management-app/dist/644.js 794 B 0 B
packages/esm-bed-management-app/dist/652.js 794 B 0 B
packages/esm-bed-management-app/dist/673.js 795 B 0 B
packages/esm-bed-management-app/dist/705.js 794 B 0 B
packages/esm-bed-management-app/dist/711.js 794 B 0 B
packages/esm-bed-management-app/dist/727.js 794 B 0 B
packages/esm-bed-management-app/dist/737.js 794 B 0 B
packages/esm-bed-management-app/dist/744.js 1.01 kB 0 B
packages/esm-bed-management-app/dist/746.js 125 kB 0 B
packages/esm-bed-management-app/dist/757.js 939 B 0 B
packages/esm-bed-management-app/dist/768.js 26.5 kB 0 B
packages/esm-bed-management-app/dist/784.js 2.63 kB 0 B
packages/esm-bed-management-app/dist/788.js 793 B 0 B
packages/esm-bed-management-app/dist/807.js 793 B 0 B
packages/esm-bed-management-app/dist/833.js 957 B 0 B
packages/esm-bed-management-app/dist/899.js 792 B 0 B
packages/esm-bed-management-app/dist/main.js 4.19 kB 0 B
packages/esm-bed-management-app/dist/openmrs-esm-bed-management-app.js 3.43 kB 0 B
packages/esm-patient-list-management-app/dist/130.js 394 kB 0 B
packages/esm-patient-list-management-app/dist/233.js 3.38 kB 0 B
packages/esm-patient-list-management-app/dist/236.js 1.34 kB 0 B
packages/esm-patient-list-management-app/dist/240.js 1.34 kB 0 B
packages/esm-patient-list-management-app/dist/261.js 1.34 kB 0 B
packages/esm-patient-list-management-app/dist/271.js 1.6 kB 0 B
packages/esm-patient-list-management-app/dist/272.js 1.34 kB 0 B
packages/esm-patient-list-management-app/dist/319.js 1.52 kB 0 B
packages/esm-patient-list-management-app/dist/325.js 3.09 kB 0 B
packages/esm-patient-list-management-app/dist/336.js 1.34 kB 0 B
packages/esm-patient-list-management-app/dist/37.js 12.5 kB 0 B
packages/esm-patient-list-management-app/dist/378.js 1.55 kB 0 B
packages/esm-patient-list-management-app/dist/443.js 6.98 kB 0 B
packages/esm-patient-list-management-app/dist/460.js 1.71 kB 0 B
packages/esm-patient-list-management-app/dist/539.js 1.34 kB 0 B
packages/esm-patient-list-management-app/dist/548.js 58.5 kB 0 B
packages/esm-patient-list-management-app/dist/574.js 1.34 kB 0 B
packages/esm-patient-list-management-app/dist/591.js 16.9 kB 0 B
packages/esm-patient-list-management-app/dist/644.js 1.6 kB 0 B
packages/esm-patient-list-management-app/dist/652.js 1.34 kB 0 B
packages/esm-patient-list-management-app/dist/673.js 1.34 kB 0 B
packages/esm-patient-list-management-app/dist/705.js 1.34 kB 0 B
packages/esm-patient-list-management-app/dist/711.js 1.34 kB 0 B
packages/esm-patient-list-management-app/dist/727.js 1.34 kB 0 B
packages/esm-patient-list-management-app/dist/737.js 1.34 kB 0 B
packages/esm-patient-list-management-app/dist/744.js 1.72 kB 0 B
packages/esm-patient-list-management-app/dist/757.js 1.64 kB 0 B
packages/esm-patient-list-management-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-list-management-app/dist/788.js 1.34 kB 0 B
packages/esm-patient-list-management-app/dist/807.js 1.83 kB 0 B
packages/esm-patient-list-management-app/dist/814.js 3.05 kB 0 B
packages/esm-patient-list-management-app/dist/833.js 1.6 kB 0 B
packages/esm-patient-list-management-app/dist/899.js 1.34 kB 0 B
packages/esm-patient-list-management-app/dist/900.js 115 kB 0 B
packages/esm-patient-list-management-app/dist/main.js 176 kB 0 B
packages/esm-patient-list-management-app/dist/openmrs-esm-patient-list-management-app.js 3.48 kB 0 B
packages/esm-patient-registration-app/dist/130.js 394 kB 0 B
packages/esm-patient-registration-app/dist/169.js 6.71 kB 0 B
packages/esm-patient-registration-app/dist/2.js 2.24 kB 0 B
packages/esm-patient-registration-app/dist/236.js 2.12 kB 0 B
packages/esm-patient-registration-app/dist/240.js 2.12 kB 0 B
packages/esm-patient-registration-app/dist/250.js 526 B 0 B
packages/esm-patient-registration-app/dist/261.js 2.12 kB 0 B
packages/esm-patient-registration-app/dist/271.js 2.51 kB 0 B
packages/esm-patient-registration-app/dist/272.js 2.12 kB 0 B
packages/esm-patient-registration-app/dist/319.js 2.43 kB 0 B
packages/esm-patient-registration-app/dist/325.js 3.09 kB 0 B
packages/esm-patient-registration-app/dist/336.js 2.12 kB 0 B
packages/esm-patient-registration-app/dist/371.js 547 B 0 B
packages/esm-patient-registration-app/dist/372.js 2.57 kB 0 B
packages/esm-patient-registration-app/dist/378.js 2.37 kB 0 B
packages/esm-patient-registration-app/dist/46.js 133 kB 0 B
packages/esm-patient-registration-app/dist/460.js 2.51 kB 0 B
packages/esm-patient-registration-app/dist/501.js 7.03 kB 0 B
packages/esm-patient-registration-app/dist/539.js 2.12 kB 0 B
packages/esm-patient-registration-app/dist/574.js 2.12 kB 0 B
packages/esm-patient-registration-app/dist/591.js 16.8 kB 0 B
packages/esm-patient-registration-app/dist/644.js 2.51 kB 0 B
packages/esm-patient-registration-app/dist/652.js 2.12 kB 0 B
packages/esm-patient-registration-app/dist/662.js 453 B 0 B
packages/esm-patient-registration-app/dist/673.js 2.12 kB 0 B
packages/esm-patient-registration-app/dist/705.js 2.12 kB 0 B
packages/esm-patient-registration-app/dist/711.js 2.12 kB 0 B
packages/esm-patient-registration-app/dist/727.js 2.12 kB 0 B
packages/esm-patient-registration-app/dist/737.js 2.12 kB 0 B
packages/esm-patient-registration-app/dist/744.js 2.56 kB 0 B
packages/esm-patient-registration-app/dist/745.js 71.5 kB 0 B
packages/esm-patient-registration-app/dist/757.js 2.54 kB 0 B
packages/esm-patient-registration-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-registration-app/dist/788.js 2.12 kB 0 B
packages/esm-patient-registration-app/dist/807.js 2.74 kB 0 B
packages/esm-patient-registration-app/dist/833.js 2.39 kB 0 B
packages/esm-patient-registration-app/dist/879.js 3.03 kB 0 B
packages/esm-patient-registration-app/dist/899.js 2.12 kB 0 B
packages/esm-patient-registration-app/dist/main.js 205 kB 0 B
packages/esm-patient-registration-app/dist/openmrs-esm-patient-registration-app.js 3.52 kB 0 B
packages/esm-patient-search-app/dist/130.js 394 kB 0 B
packages/esm-patient-search-app/dist/2.js 2.23 kB 0 B
packages/esm-patient-search-app/dist/233.js 3.37 kB 0 B
packages/esm-patient-search-app/dist/236.js 799 B 0 B
packages/esm-patient-search-app/dist/240.js 801 B 0 B
packages/esm-patient-search-app/dist/261.js 801 B 0 B
packages/esm-patient-search-app/dist/271.js 1 kB 0 B
packages/esm-patient-search-app/dist/272.js 801 B 0 B
packages/esm-patient-search-app/dist/319.js 958 B 0 B
packages/esm-patient-search-app/dist/325.js 3.09 kB 0 B
packages/esm-patient-search-app/dist/336.js 800 B 0 B
packages/esm-patient-search-app/dist/372.js 2.57 kB 0 B
packages/esm-patient-search-app/dist/378.js 952 B 0 B
packages/esm-patient-search-app/dist/443.js 6.98 kB 0 B
packages/esm-patient-search-app/dist/460.js 1.01 kB 0 B
packages/esm-patient-search-app/dist/51.js 105 kB 0 B
packages/esm-patient-search-app/dist/539.js 799 B 0 B
packages/esm-patient-search-app/dist/574.js 937 B +136 B (+16.98%) ⚠️
packages/esm-patient-search-app/dist/591.js 16.8 kB 0 B
packages/esm-patient-search-app/dist/644.js 1 kB 0 B
packages/esm-patient-search-app/dist/652.js 801 B 0 B
packages/esm-patient-search-app/dist/673.js 801 B 0 B
packages/esm-patient-search-app/dist/705.js 801 B 0 B
packages/esm-patient-search-app/dist/711.js 801 B 0 B
packages/esm-patient-search-app/dist/727.js 801 B 0 B
packages/esm-patient-search-app/dist/737.js 800 B 0 B
packages/esm-patient-search-app/dist/744.js 1.04 kB 0 B
packages/esm-patient-search-app/dist/750.js 60.8 kB +7.24 kB (+13.52%) ⚠️
packages/esm-patient-search-app/dist/757.js 953 B 0 B
packages/esm-patient-search-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-search-app/dist/788.js 797 B 0 B
packages/esm-patient-search-app/dist/807.js 1.1 kB 0 B
packages/esm-patient-search-app/dist/814.js 3.05 kB 0 B
packages/esm-patient-search-app/dist/833.js 965 B 0 B
packages/esm-patient-search-app/dist/899.js 797 B 0 B
packages/esm-patient-search-app/dist/openmrs-esm-patient-search-app.js 3.51 kB +37 B (+1.06%)
packages/esm-service-queues-app/dist/1006.js 1.75 kB 0 B
packages/esm-service-queues-app/dist/1060.js 1.82 kB 0 B
packages/esm-service-queues-app/dist/130.js 394 kB 0 B
packages/esm-service-queues-app/dist/1325.js 3.09 kB 0 B
packages/esm-service-queues-app/dist/1644.js 4.05 kB 0 B
packages/esm-service-queues-app/dist/1727.js 8.11 kB 0 B
packages/esm-service-queues-app/dist/1800.js 1.67 kB 0 B
packages/esm-service-queues-app/dist/2.js 2.23 kB 0 B
packages/esm-service-queues-app/dist/236.js 3.4 kB 0 B
packages/esm-service-queues-app/dist/2754.js 180 kB 0 B
packages/esm-service-queues-app/dist/2757.js 4.14 kB 0 B
packages/esm-service-queues-app/dist/2760.js 7.3 kB 0 B
packages/esm-service-queues-app/dist/2784.js 2.62 kB 0 B
packages/esm-service-queues-app/dist/3199.js 1.36 kB 0 B
packages/esm-service-queues-app/dist/3372.js 2.57 kB 0 B
packages/esm-service-queues-app/dist/3574.js 3.39 kB 0 B
packages/esm-service-queues-app/dist/3604.js 6.96 kB 0 B
packages/esm-service-queues-app/dist/3652.js 3.39 kB 0 B
packages/esm-service-queues-app/dist/3818.js 2.56 kB 0 B
packages/esm-service-queues-app/dist/3828.js 1.38 kB 0 B
packages/esm-service-queues-app/dist/4272.js 3.39 kB 0 B
packages/esm-service-queues-app/dist/4378.js 3.88 kB 0 B
packages/esm-service-queues-app/dist/443.js 6.98 kB 0 B
packages/esm-service-queues-app/dist/4460.js 4.25 kB 0 B
packages/esm-service-queues-app/dist/4705.js 3.39 kB 0 B
packages/esm-service-queues-app/dist/4748.js 119 kB 0 B
packages/esm-service-queues-app/dist/4911.js 7.76 kB 0 B
packages/esm-service-queues-app/dist/5236.js 5.98 kB 0 B
packages/esm-service-queues-app/dist/5240.js 3.39 kB 0 B
packages/esm-service-queues-app/dist/5282.js 8.98 kB 0 B
packages/esm-service-queues-app/dist/5336.js 3.39 kB 0 B
packages/esm-service-queues-app/dist/539.js 3.4 kB 0 B
packages/esm-service-queues-app/dist/5673.js 3.39 kB 0 B
packages/esm-service-queues-app/dist/5711.js 3.39 kB 0 B
packages/esm-service-queues-app/dist/5737.js 3.39 kB 0 B
packages/esm-service-queues-app/dist/5833.js 3.97 kB 0 B
packages/esm-service-queues-app/dist/6591.js 16.8 kB 0 B
packages/esm-service-queues-app/dist/6670.js 10.1 kB 0 B
packages/esm-service-queues-app/dist/6727.js 3.39 kB 0 B
packages/esm-service-queues-app/dist/744.js 4.17 kB 0 B
packages/esm-service-queues-app/dist/752.js 1.61 kB 0 B
packages/esm-service-queues-app/dist/7807.js 4.52 kB 0 B
packages/esm-service-queues-app/dist/8271.js 4.05 kB 0 B
packages/esm-service-queues-app/dist/8319.js 3.86 kB 0 B
packages/esm-service-queues-app/dist/8788.js 3.41 kB 0 B
packages/esm-service-queues-app/dist/899.js 3.39 kB 0 B
packages/esm-service-queues-app/dist/9261.js 3.39 kB 0 B
packages/esm-service-queues-app/dist/9392.js 7.84 kB 0 B
packages/esm-service-queues-app/dist/940.js 21.4 kB 0 B
packages/esm-service-queues-app/dist/main.js 300 kB 0 B
packages/esm-service-queues-app/dist/openmrs-esm-service-queues-app.js 3.48 kB 0 B
packages/esm-ward-app/dist/109.js 350 B 0 B
packages/esm-ward-app/dist/124.js 3.68 kB 0 B
packages/esm-ward-app/dist/125.js 5.87 kB 0 B
packages/esm-ward-app/dist/126.js 9.69 kB 0 B
packages/esm-ward-app/dist/130.js 394 kB 0 B
packages/esm-ward-app/dist/146.js 2.13 kB 0 B
packages/esm-ward-app/dist/15.js 480 B 0 B
packages/esm-ward-app/dist/325.js 3.08 kB 0 B
packages/esm-ward-app/dist/348.js 349 B 0 B
packages/esm-ward-app/dist/362.js 476 B 0 B
packages/esm-ward-app/dist/372.js 2.56 kB 0 B
packages/esm-ward-app/dist/443.js 6.97 kB 0 B
packages/esm-ward-app/dist/471.js 6.88 kB 0 B
packages/esm-ward-app/dist/481.js 1.25 kB 0 B
packages/esm-ward-app/dist/53.js 12.2 kB 0 B
packages/esm-ward-app/dist/55.js 628 B 0 B
packages/esm-ward-app/dist/559.js 342 B 0 B
packages/esm-ward-app/dist/574.js 1.63 kB 0 B
packages/esm-ward-app/dist/576.js 6.03 kB 0 B
packages/esm-ward-app/dist/577.js 17.7 kB 0 B
packages/esm-ward-app/dist/591.js 16.8 kB 0 B
packages/esm-ward-app/dist/598.js 35.7 kB 0 B
packages/esm-ward-app/dist/649.js 2.51 kB 0 B
packages/esm-ward-app/dist/662.js 11.1 kB 0 B
packages/esm-ward-app/dist/767.js 648 B 0 B
packages/esm-ward-app/dist/784.js 2.62 kB 0 B
packages/esm-ward-app/dist/921.js 6.09 kB 0 B
packages/esm-ward-app/dist/922.js 9.04 kB 0 B
packages/esm-ward-app/dist/925.js 90.9 kB 0 B
packages/esm-ward-app/dist/940.js 21.4 kB 0 B
packages/esm-ward-app/dist/969.js 202 B 0 B
packages/esm-ward-app/dist/main.js 98.5 kB 0 B
packages/esm-ward-app/dist/openmrs-esm-ward-app.js 3.46 kB 0 B

compressed-size-action

@usamaidrsk usamaidrsk marked this pull request as ready for review November 8, 2024 07:40
@usamaidrsk usamaidrsk changed the title (feat) O3-4180: Configure Advanced search filter with to support person attributes (feat) O3-4180: Configure Advanced search filter to support person attributes Nov 8, 2024
@usamaidrsk usamaidrsk requested a review from chibongho November 8, 2024 15:13
@denniskigen denniskigen requested a review from ibacher November 21, 2024 10:58
@usamaidrsk usamaidrsk requested a review from brandones November 26, 2024 06:05
Copy link
Member

@vasharma05 vasharma05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes/ updates needed. If you can, move the form handling to RHF, rather than reducer based updation, for better validations and handling.

@usamaidrsk usamaidrsk requested a review from vasharma05 December 4, 2024 06:40
packages/esm-patient-search-app/src/config-schema.ts Outdated Show resolved Hide resolved
_type: Type.UUID,
_description: 'Answer concept UUID',
},
label: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not allow passing labels, it's another hassle to handle the translations, the labels should be used from the backend.

@usamaidrsk usamaidrsk requested a review from vasharma05 December 5, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants