(feat) O3-4235: Add config support for observations display on active visits table #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +3.18 kB (+0.04%) Total Size: 7.16 MB ℹ️ View Unchanged
|
|
Size Change: +3.19 kB (+0.04%) Total Size: 7.16 MB ℹ️ View Unchanged
|
vasharma05
reviewed
Dec 2, 2024
packages/esm-active-visits-app/src/active-visits-widget/active-visits.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-active-visits-app/src/active-visits-widget/active-visits.component.tsx
Show resolved
Hide resolved
usamaidrsk
force-pushed
the
ft-O3-4235
branch
from
baf57a7 to
f0bee53
Compare
vasharma05
approved these changes
Dec 3, 2024
| }; | ||
| } | ||
|
|
||
| export function useTableHeaders(t, config, obsConcepts) { |
There was a problem hiding this comment.
Since this is a hook, you can directly use the useTranslation and useConfig in this hook.
|
|
||
| const patientChartUrl = '${openmrsSpaBase}/patient/${patientUuid}/chart/Patient%20Summary'; | ||
| const patientChartUrl = '${openmrsSpaBase}/patient/${patientUuid}/chart/Patient%20Summary'; |
There was a problem hiding this comment.
You need to redirect to just /chart and the dashboard to redirect, let it be Patient Summary or any other is handled by the patient chart itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR adds configuration support for displaying observation(s) as columns on the active visits table. This add obs array to activeVisits config schema to specify obs concept UUIDs, that should be displayed.
Testing:
{ "activeVisits": { "obs": ["aea577dc-738f-4b8c-8d7d-07eb720e8a1f","163688AAAAAAAAAAAAAAAAAAAAAAAAAAAAAA"] } }Screenshots
Related Issue
Other
https://openmrs.atlassian.net/browse/O3-4235