(refactor) e2e: Centralize types and improve type usage #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 7.18 MB ℹ️ View Unchanged
|
This PR centralizes type annotations used in e2e tests and improves type usage. Key changes include: - Adding the Playwright ESLint plugin to enforce best practices in e2e tests. - Moving test-specific types to a dedicated types file and importing them where needed. - Using consistent type imports in e2e tests. - Cleaning up eslint overrides for various test file types. With these changes, e2e tests should be more consistent and easier to maintain.
denniskigen
force-pushed
the
refactor/e2e
branch
from
d705334 to
4c43f75
Compare
chibongho
approved these changes
Dec 13, 2024
ibacher
approved these changes
Dec 13, 2024
Comment on lines
+6
to
+16
| "overrides": [ | ||
| { | ||
| "files": ["**/*.test.tsx"], | ||
| "extends": ["plugin:testing-library/react"] | ||
| }, | ||
| { | ||
| "files": ["e2e/**/*.spec.ts"], | ||
| "extends": ["plugin:playwright/recommended"], | ||
| "rules": { | ||
| "testing-library/prefer-screen-queries": "off" | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR centralizes type annotations used in e2e tests and improves type usage. Key changes include:
With these changes, e2e tests should be more consistent and easier to maintain.
Screenshots
Related Issue
Other