Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Add debouncing to patient list search and fix search component height on tablet #774

Closed
wants to merge 6 commits into from

Conversation

Jexsie
Copy link
Contributor

@Jexsie Jexsie commented Aug 7, 2023

Requirements

Summary

  • Adds debouncing to list searching
  • Fixes the height of the search component inside the patient tablet from xl to lg on tablet

Screenshots

None.

Screenshot from 2023-08-07 11-45-08

image

Related Issue

None.

Other

None.

@Jexsie
Copy link
Contributor Author

Jexsie commented Aug 7, 2023

cc @vasharma05

@Jexsie Jexsie changed the title (feat) Add debouncing to list searching and fix search component height on tablet (feat) Add debouncing to patient list search and fix search component height on tablet Aug 7, 2023
Copy link
Member

@vasharma05 vasharma05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Just a small change

@denniskigen
Copy link
Member

@vasharma05, can this leverage the useDebounce hook you added to Core?

@vasharma05
Copy link
Member

vasharma05 commented Sep 21, 2023

Exactly @denniskigen, it's a line change for this PR using debounce.
I'll take the PR ahead.

@Jexsie
Copy link
Contributor Author

Jexsie commented Sep 21, 2023

i think i can handle it @vasharma05 . Please also take a look at my other PRs

@denniskigen
Copy link
Member

Closing as this is obviated by #865.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants