Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

O3-2461: Can't select earlier date on Appointments form #827

Merged
merged 1 commit into from
Oct 2, 2023
Merged

O3-2461: Can't select earlier date on Appointments form #827

merged 1 commit into from
Oct 2, 2023

Conversation

mogoodrich
Copy link
Member

See: https://issues.openmrs.org/browse/O3-2461

Requirements

Summary

Screenshots

None.

Related Issue

None.

Other

None.

mogoodrich
mogoodrich commented Sep 29, 2023
View reviewed changes
...esm-appointments-app/src/appointments/forms/create-edit-form/appointments-form.component.tsx
@@ -217,7 +218,7 @@ const AppointmentForm: React.FC<AppointmentFormProps> = ({ appointment, patientU
dateFormat="d/m/Y"
datePickerType="single"
id="visitDate"
minDate={patientAppointment.visitDate}
minDate={today}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I set the minDate to be "today", which seems reasnable for a POC scheduling functionality. I'm fine with removing any constraint if people think that is better to allow retrospectively entering/scheduling appointments after they already should have happened.

@github-actions
Copy link
Contributor

Size Change: +14 B (0%)

Total Size: 2.36 MB

ℹ️ View Unchanged
Filename Size Change
packages/esm-active-visits-app/dist/130.js 175 kB 0 B
packages/esm-active-visits-app/dist/316.js 42.9 kB 0 B
packages/esm-active-visits-app/dist/319.js 620 B 0 B
packages/esm-active-visits-app/dist/574.js 543 B 0 B
packages/esm-active-visits-app/dist/588.js 6.66 kB 0 B
packages/esm-active-visits-app/dist/629.js 7.48 kB 0 B
packages/esm-active-visits-app/dist/757.js 637 B 0 B
packages/esm-active-visits-app/dist/784.js 2.63 kB 0 B
packages/esm-active-visits-app/dist/788.js 540 B 0 B
packages/esm-active-visits-app/dist/807.js 856 B 0 B
packages/esm-active-visits-app/dist/833.js 660 B 0 B
packages/esm-active-visits-app/dist/842.js 881 B 0 B
packages/esm-active-visits-app/dist/879.js 2.94 kB 0 B
packages/esm-active-visits-app/dist/909.js 54.2 kB 0 B
packages/esm-active-visits-app/dist/936.js 7.97 kB 0 B
packages/esm-active-visits-app/dist/main.js 3.39 kB 0 B
packages/esm-active-visits-app/dist/openmrs-esm-active-visits-app.js 3.22 kB 0 B
packages/esm-appointments-app/dist/130.js 175 kB 0 B
packages/esm-appointments-app/dist/212.js 103 kB 0 B
packages/esm-appointments-app/dist/223.js 20.9 kB 0 B
packages/esm-appointments-app/dist/319.js 1.92 kB 0 B
packages/esm-appointments-app/dist/328.js 11.8 kB +14 B (0%)
packages/esm-appointments-app/dist/381.js 10.1 kB 0 B
packages/esm-appointments-app/dist/437.js 2.46 kB 0 B
packages/esm-appointments-app/dist/469.js 6.65 kB 0 B
packages/esm-appointments-app/dist/544.js 748 B 0 B
packages/esm-appointments-app/dist/574.js 1.73 kB 0 B
packages/esm-appointments-app/dist/591.js 16.9 kB 0 B
packages/esm-appointments-app/dist/610.js 6.71 kB 0 B
packages/esm-appointments-app/dist/735.js 11.3 kB 0 B
packages/esm-appointments-app/dist/738.js 144 kB 0 B
packages/esm-appointments-app/dist/757.js 1.74 kB 0 B
packages/esm-appointments-app/dist/784.js 2.63 kB 0 B
packages/esm-appointments-app/dist/788.js 1.74 kB 0 B
packages/esm-appointments-app/dist/80.js 5.1 kB 0 B
packages/esm-appointments-app/dist/807.js 2.43 kB 0 B
packages/esm-appointments-app/dist/833.js 2.03 kB 0 B
packages/esm-appointments-app/dist/884.js 1.96 kB 0 B
packages/esm-appointments-app/dist/main.js 5.5 kB 0 B
packages/esm-appointments-app/dist/openmrs-esm-appointments-app.js 3.18 kB 0 B
packages/esm-patient-list-app/dist/130.js 175 kB 0 B
packages/esm-patient-list-app/dist/255.js 4.4 kB 0 B
packages/esm-patient-list-app/dist/292.js 96 kB 0 B
packages/esm-patient-list-app/dist/294.js 3.32 kB 0 B
packages/esm-patient-list-app/dist/319.js 1.08 kB 0 B
packages/esm-patient-list-app/dist/404.js 2.25 kB 0 B
packages/esm-patient-list-app/dist/477.js 16.3 kB 0 B
packages/esm-patient-list-app/dist/537.js 534 B 0 B
packages/esm-patient-list-app/dist/565.js 2.61 kB 0 B
packages/esm-patient-list-app/dist/574.js 942 B 0 B
packages/esm-patient-list-app/dist/588.js 6.66 kB 0 B
packages/esm-patient-list-app/dist/591.js 16.9 kB 0 B
packages/esm-patient-list-app/dist/716.js 4.62 kB 0 B
packages/esm-patient-list-app/dist/757.js 1.09 kB 0 B
packages/esm-patient-list-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-list-app/dist/788.js 941 B 0 B
packages/esm-patient-list-app/dist/791.js 1.54 kB 0 B
packages/esm-patient-list-app/dist/807.js 1.37 kB 0 B
packages/esm-patient-list-app/dist/833.js 1.13 kB 0 B
packages/esm-patient-list-app/dist/900.js 7.66 kB 0 B
packages/esm-patient-list-app/dist/main.js 3.81 kB 0 B
packages/esm-patient-list-app/dist/openmrs-esm-patient-list-app.js 3.18 kB 0 B
packages/esm-patient-registration-app/dist/117.js 12.1 kB 0 B
packages/esm-patient-registration-app/dist/130.js 175 kB 0 B
packages/esm-patient-registration-app/dist/167.js 27 kB 0 B
packages/esm-patient-registration-app/dist/294.js 23.4 kB 0 B
packages/esm-patient-registration-app/dist/319.js 1.59 kB 0 B
packages/esm-patient-registration-app/dist/485.js 29 kB 0 B
packages/esm-patient-registration-app/dist/537.js 3.74 kB 0 B
packages/esm-patient-registration-app/dist/558.js 26 kB 0 B
packages/esm-patient-registration-app/dist/574.js 1.36 kB 0 B
packages/esm-patient-registration-app/dist/591.js 16.9 kB 0 B
packages/esm-patient-registration-app/dist/62.js 6.86 kB 0 B
packages/esm-patient-registration-app/dist/635.js 456 B 0 B
packages/esm-patient-registration-app/dist/68.js 9.33 kB 0 B
packages/esm-patient-registration-app/dist/735.js 464 B 0 B
packages/esm-patient-registration-app/dist/742.js 721 B 0 B
packages/esm-patient-registration-app/dist/757.js 1.62 kB 0 B
packages/esm-patient-registration-app/dist/784.js 2.64 kB 0 B
packages/esm-patient-registration-app/dist/788.js 1.29 kB 0 B
packages/esm-patient-registration-app/dist/807.js 2.05 kB 0 B
packages/esm-patient-registration-app/dist/833.js 1.59 kB 0 B
packages/esm-patient-registration-app/dist/857.js 2.08 kB 0 B
packages/esm-patient-registration-app/dist/879.js 2.94 kB 0 B
packages/esm-patient-registration-app/dist/975.js 425 B 0 B
packages/esm-patient-registration-app/dist/main.js 21.6 kB 0 B
packages/esm-patient-registration-app/dist/openmrs-esm-patient-registration-app.js 3.23 kB 0 B
packages/esm-patient-search-app/dist/110.js 17 kB 0 B
packages/esm-patient-search-app/dist/128.js 2.01 kB 0 B
packages/esm-patient-search-app/dist/130.js 175 kB 0 B
packages/esm-patient-search-app/dist/262.js 29.4 kB 0 B
packages/esm-patient-search-app/dist/319.js 940 B 0 B
packages/esm-patient-search-app/dist/327.js 1.05 kB 0 B
packages/esm-patient-search-app/dist/357.js 5.72 kB 0 B
packages/esm-patient-search-app/dist/519.js 5.08 kB 0 B
packages/esm-patient-search-app/dist/574.js 792 B 0 B
packages/esm-patient-search-app/dist/588.js 6.66 kB 0 B
packages/esm-patient-search-app/dist/591.js 16.9 kB 0 B
packages/esm-patient-search-app/dist/757.js 923 B 0 B
packages/esm-patient-search-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-search-app/dist/788.js 778 B 0 B
packages/esm-patient-search-app/dist/807.js 1.12 kB 0 B
packages/esm-patient-search-app/dist/833.js 947 B 0 B
packages/esm-patient-search-app/dist/842.js 2.06 kB 0 B
packages/esm-patient-search-app/dist/939.js 4.42 kB 0 B
packages/esm-patient-search-app/dist/982.js 1.69 kB 0 B
packages/esm-patient-search-app/dist/main.js 3.45 kB 0 B
packages/esm-patient-search-app/dist/openmrs-esm-patient-search-app.js 3.19 kB 0 B
packages/esm-service-queues-app/dist/130.js 175 kB 0 B
packages/esm-service-queues-app/dist/176.js 5.76 kB 0 B
packages/esm-service-queues-app/dist/242.js 219 B 0 B
packages/esm-service-queues-app/dist/252.js 2.22 kB 0 B
packages/esm-service-queues-app/dist/286.js 2.88 kB 0 B
packages/esm-service-queues-app/dist/308.js 8.15 kB 0 B
packages/esm-service-queues-app/dist/311.js 4.19 kB 0 B
packages/esm-service-queues-app/dist/319.js 3.08 kB 0 B
packages/esm-service-queues-app/dist/328.js 3.1 kB 0 B
packages/esm-service-queues-app/dist/330.js 8.6 kB 0 B
packages/esm-service-queues-app/dist/364.js 2.03 kB 0 B
packages/esm-service-queues-app/dist/425.js 3.45 kB 0 B
packages/esm-service-queues-app/dist/433.js 25.7 kB 0 B
packages/esm-service-queues-app/dist/457.js 2.5 kB 0 B
packages/esm-service-queues-app/dist/469.js 6.66 kB 0 B
packages/esm-service-queues-app/dist/53.js 3.15 kB 0 B
packages/esm-service-queues-app/dist/574.js 3.1 kB 0 B
packages/esm-service-queues-app/dist/591.js 16.9 kB 0 B
packages/esm-service-queues-app/dist/610.js 6.71 kB 0 B
packages/esm-service-queues-app/dist/611.js 2.73 kB 0 B
packages/esm-service-queues-app/dist/616.js 3.61 kB 0 B
packages/esm-service-queues-app/dist/627.js 2.94 kB 0 B
packages/esm-service-queues-app/dist/644.js 1.25 kB 0 B
packages/esm-service-queues-app/dist/670.js 155 kB 0 B
packages/esm-service-queues-app/dist/680.js 2.55 kB 0 B
packages/esm-service-queues-app/dist/719.js 5.38 kB 0 B
packages/esm-service-queues-app/dist/733.js 4.09 kB 0 B
packages/esm-service-queues-app/dist/757.js 3.08 kB 0 B
packages/esm-service-queues-app/dist/764.js 5.26 kB 0 B
packages/esm-service-queues-app/dist/766.js 4.74 kB 0 B
packages/esm-service-queues-app/dist/784.js 2.63 kB 0 B
packages/esm-service-queues-app/dist/788.js 3.08 kB 0 B
packages/esm-service-queues-app/dist/807.js 4.46 kB 0 B
packages/esm-service-queues-app/dist/833.js 3.68 kB 0 B
packages/esm-service-queues-app/dist/86.js 4.42 kB 0 B
packages/esm-service-queues-app/dist/981.js 3.63 kB 0 B
packages/esm-service-queues-app/dist/main.js 4 kB 0 B
packages/esm-service-queues-app/dist/openmrs-esm-service-queues-app.js 3.19 kB 0 B

compressed-size-action

@makombe makombe merged commit d810b48 into main Oct 2, 2023
6 checks passed
@makombe makombe deleted the O3-2461 branch October 2, 2023 07:44
@mogoodrich
Copy link
Member Author

Thanks @makombe and @donaldkibet !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donaldkibet donaldkibet donaldkibet approved these changes

@makombe makombe makombe approved these changes

@CynthiaKamau CynthiaKamau Awaiting requested review from CynthiaKamau

@mseaton mseaton Awaiting requested review from mseaton

@denniskigen denniskigen Awaiting requested review from denniskigen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mogoodrich @makombe @donaldkibet