-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FM2-136 : Appointment resource initial implementation #136
Conversation
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
============================================
+ Coverage 90.40% 90.43% +0.03%
- Complexity 1206 1212 +6
============================================
Files 128 130 +2
Lines 2834 2843 +9
Branches 353 354 +1
============================================
+ Hits 2562 2571 +9
Misses 147 147
Partials 125 125
Continue to review full report at Codecov.
|
api/src/main/java/org/openmrs/module/fhir2/api/translators/AppointmentTranslator.java
Outdated
Show resolved
Hide resolved
well done @jecihjoy , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can however be merged to free this PR , And it will leverage code workflow and tracking, Am thinking since this is the initial implementation it would be more clear to track different changes that may come along, cc @mozzy11 we also need to track mappings for appointmentResources FYI cc @ibacher @mozzy11
Hello @sherrif10 |
@corneliouzbett , Thanks for the updates will follow up with the pr you shared |
Description of what I changed
Added an initial implementation for appointment resource
Issue I worked on
see https://issues.openmrs.org/browse/FM2-136
Checklist: I completed these to help reviewers :)
My pull request only contains ONE single commit.
No? -> read here on how to squash multiple commits into one
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amend
I have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amend
I ran
mvn clean package
right before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master