Correction of errors in examples on cadences page #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two of the examples of compound cadences on the cadences page are incorrect; figures do not match voice-leading. I have edited the .ly source file and compiled a new .pdf of the whole, but for some reason I haven't been able to extract new .pngs of the individual examples. I was trying to do this with lilypond -dclip-systems, but failed. I recommend the maintainers adopt my Cadences.ly and Cadences.pdf files and generate new .png snippets for this page.
My additions/modifications to the text of cadenceTypes.md are not necessarily recommended for general adoption.