Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better messaging handling #187

Merged
merged 16 commits into from
Aug 22, 2023
Merged

Better messaging handling #187

merged 16 commits into from
Aug 22, 2023

Conversation

Melkiades
Copy link
Collaborator

@Melkiades Melkiades commented Aug 11, 2023

Fix #183

Now the printing is slimmer:

> x <- dependency_table(project = "../rtables/", verbose = 1)
Copying local dir /home/garolind/NEST/rtables to cache dir...
fetch https://github.com/insightsengineering/formatters.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/tern.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/tern.mmrm.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/tern.rbmi.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/teal.widgets.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/teal.modules.clinical.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/teal.modules.general.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/teal.modules.hermes.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/chevron.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/citril.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/teal.reporter.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/tern.gee.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/scda.test.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/rlistings.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/teal.osprey.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/nestcolor.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/biomarker-catalog.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/osprey.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/teal.goshawk.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/teal.modules.helios.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/tlg-catalog.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/teal.slice.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/teal.transform.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/teal.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/teal.logger.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/teal.code.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/teal.data.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/hermes.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/dunlin.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/citril.metadata.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/scda.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/scda.2022.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/goshawk.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/teal.devel.git in cache directory...
   - checkout branch origin/main in cache directory...
fetch https://github.com/insightsengineering/helios.git in cache directory...
   - checkout branch origin/main in cache directory...
Current cache directory: /home/user/.staged.dependencies/packages_cache

The same verbosity can be reached with verbose = 2

@Melkiades Melkiades added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 11, 2023
@Melkiades Melkiades marked this pull request as ready for review August 22, 2023 12:38
@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023

Unit Tests Summary

    1 files    13 suites   12s ⏱️
  71 tests   71 ✔️ 0 💤 0
215 runs  215 ✔️ 0 💤 0

Results for commit 993c6b9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

badge

Code Coverage Summary

Filename                   Stmts    Miss  Cover    Missing
-----------------------  -------  ------  -------  -----------------------------------------------------------------------------------------------------------------------
R/caching.R                  173       6  96.53%   47, 75, 141-144
R/dependencies_app.R         134     134  0.00%    39-199
R/dependencies_helper.R      238      72  69.75%   42-43, 47, 52-55, 91-107, 113-122, 127-134, 140-143, 148-155, 161, 169-175, 231, 265, 276-294, 305, 414
R/dependencies.R             356      48  86.52%   87, 94, 110, 127, 211-227, 269, 277-280, 282, 295, 380, 384-385, 451, 455-456, 501-514, 555-556, 561, 632-633, 640, 730
R/git_tools.R                198      89  55.05%   75, 94-101, 104, 109, 142-145, 168-180, 195-219, 257-333
R/graph_methods.R             71       1  98.59%   115
R/host.R                      19      10  47.37%   5-8, 19-25
R/ref_strategy.R              44       0  100.00%
R/renv.R                      13       0  100.00%
R/rstudio_addins.R             5       5  0.00%    6-22
R/rstudio_jobs.R              27      27  0.00%    3-74
R/utils.R                    113       6  94.69%   3, 119, 128-129, 138, 148
R/zzz.R                       23      14  39.13%   30-44
TOTAL                       1414     412  70.86%

Results for commit: d17b204

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Collaborator

@cicdguy cicdguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@Melkiades Melkiades merged commit fb12499 into main Aug 22, 2023
@Melkiades Melkiades deleted the 183_better_messaging@main branch August 22, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better handling of messages' verbosity
2 participants