Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter_with_hvg: enable storing the number of highly variable genes found #647

Conversation

DriesSchaumont
Copy link
Member

Changelog

filter_with_hvg: enable storing the number of highly variable genes found

Issue ticket number and link

Closes #595 (Replace xxxx with the GitHub issue number)

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributor's guide

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI tests succeed!

@DriesSchaumont DriesSchaumont linked an issue Jan 8, 2024 that may be closed by this pull request
@DriesSchaumont DriesSchaumont marked this pull request as ready for review January 9, 2024 09:43
Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it strange to store this info in .obs.

@DriesSchaumont
Copy link
Member Author

Closing because it is unclear how to handle this (and its easy to calculate the metric on the spot from the boolean column anyway)

@DriesSchaumont DriesSchaumont deleted the 595-output-the-number-of-highly-variable-genes-selected branch April 25, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output the number of highly variable genes selected
2 participants