FEAT: Improved ODF version detection #166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added a version detection method to `PackageParserImpl` to detect the ODF version of a package; - added a `Version` field to the `OdfPackage` class to store the detected version; - added `getDetectedVersion` method to the `OdfPackage` class to return the detected version; - restored reporting of `DOC-2` for package version; - improved `POL_2` detection and messaging for non ODF 1.3 packages; - added a `Version.UNKNOWN` value to the `OdfVersion` enum; - improved formatting of error message output; and - tests for the above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PackageParserImplto detect the ODF version of a package;Versionfield to theOdfPackageclass to store the detected version;getDetectedVersionmethod to theOdfPackageclass to return the detected version;DOC-2for package version;POL_2detection and messaging for non ODF 1.3 packages;Version.UNKNOWNvalue to theOdfVersionenum;