Add basic template files #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcannood
requested changes
Jun 14, 2024
.github/test.yaml
Outdated
| list: | ||
| needs: run_ci_check_job | ||
| env: | ||
| s3_bucket: s3://openproblems-data/resources_test/cell_cell_communication |
There was a problem hiding this comment.
I think we should extract the s3_bucket from the _viash.yaml and fetch the bucket name from there. Partially related to viash-io/viash-actions#30. At the very least, we should read the task id and store it in an environment variable.
| @@ -0,0 +1,72 @@ | |||
| name: A unique identifier. Can only contain lowercase letters, numbers or underscores. | |||
There was a problem hiding this comment.
I wouldn't do this now, but I think we should try to move as many of these fields (if not all) to _viash.yaml.
rcannood
reviewed
Jun 17, 2024
rcannood
requested changes
Jun 21, 2024
.github/build.yaml
Outdated
| @@ -0,0 +1,122 @@ | |||
| name: build | |||
There was a problem hiding this comment.
The github action is in the wrong directory ;)
.github/build.yaml
Outdated
Comment on lines
32
to
73
| - name: Determine version tag from branch name | ||
| id: defaults | ||
| run: | | ||
| BRANCH_NAME=$(echo $GITHUB_REF | sed 's/refs\/heads\///') | ||
|
|
||
| VERSION=${{ github.event.inputs.version }} | ||
| if [ -z "$VERSION" ]; then | ||
| VERSION="build-$BRANCH_NAME" | ||
| fi | ||
| echo "version=$VERSION" >> $GITHUB_OUTPUT | ||
|
|
||
| TARGET_BRANCH=${{ github.event.inputs.target_branch }} | ||
| if [ -z "$TARGET_BRANCH" ]; then | ||
| TARGET_BRANCH="build-$BRANCH_NAME" | ||
| fi | ||
| echo "target_branch=$TARGET_BRANCH" >> $GITHUB_OUTPUT | ||
|
|
||
| - name: Remove target folder from .gitignore | ||
| run: | | ||
| # allow publishing the target folder | ||
| sed -i '/^\/target.*/d' .gitignore | ||
|
|
||
| - uses: viash-io/viash-actions/ns-build@v5 | ||
| with: | ||
| config_mod: .functionality.version := '${{ steps.defaults.outputs.version }}' | ||
| parallel: true | ||
|
|
||
| - name: Deploy to target branch | ||
| uses: peaceiris/actions-gh-pages@v4 | ||
| with: | ||
| github_token: ${{ secrets.GITHUB_TOKEN }} | ||
| publish_dir: . | ||
| publish_branch: ${{ steps.defaults.outputs.target_branch }} | ||
|
|
||
| - id: ns_list | ||
| uses: viash-io/viash-actions/ns-list@v5 | ||
| with: | ||
| platform: docker | ||
| src: src | ||
| format: json | ||
|
|
||
| - id: set_matrix |
There was a problem hiding this comment.
I'm working on simplifying this a little bit
.github/test.yaml
Outdated
Comment on lines
19
to
58
| if [[ "$pull_request" != "null" && "$GITHUB_REF_NAME" != "main" && "${{ github.event_name == 'push' }}" == "true" && "${{ !contains(github.event.head_commit.message, 'ci force') }}" == "true" ]]; then | ||
| echo "check=false" >> $GITHUB_OUTPUT | ||
| else | ||
| echo "check=true" >> $GITHUB_OUTPUT | ||
| fi | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GTHB_PAT }} | ||
|
|
||
| # phase 1 | ||
| list: | ||
| needs: run_ci_check_job | ||
| env: | ||
| s3_bucket: s3://openproblems-data/resources_test | ||
| runs-on: ubuntu-latest | ||
| if: ${{ needs.run_ci_check_job.outputs.run_ci == 'true' }} | ||
|
|
||
| outputs: | ||
| matrix: ${{ steps.set_matrix.outputs.matrix }} | ||
| cache_key: ${{ steps.cache.outputs.cache_key }} | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
| submodules: 'recursive' | ||
|
|
||
| - uses: christian-ci/action-yaml-github-output@v2 | ||
| with: | ||
| file_path: _viash.yaml | ||
|
|
||
| - uses: viash-io/viash-actions/setup@v5 | ||
|
|
||
| - uses: viash-io/viash-actions/project/sync-and-cache-s3@v5 | ||
| id: cache | ||
| with: | ||
| s3_bucket: $s3_bucket/$NAME | ||
| dest_path: resources | ||
| cache_key_prefix: resources__ | ||
|
|
||
| - id: ns_list |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.