Updated to openPDF 2.0.2 #662
Conversation
| uses: actions/setup-java@v4 | ||
| with: | ||
| java-version: '8' | ||
| java-version: '17' |
There was a problem hiding this comment.
XDocReport is working with Java 8 , why you need Java 17?
There was a problem hiding this comment.
Java 17 is required for OpenPDF 2.0.0 or later. The build for this pull request fails with java 8. If we want to upgrade openpdf, I don't think there is another way than to upgrade the minimum java requirement for XDocReport. Of course I'm not sure if losing java 8 support is acceptable for this project.
There was a problem hiding this comment.
I'm not sure if losing java 8 support is acceptable for this project.
No sorry, there are so many people who are using XDocReport with old Java version. We need to keep it.
@pascalleclercq do you know if we could build only the module of OpenPDF 2.0.0 with Java 17?
There was a problem hiding this comment.
The maven compiler plugin is still set to version 1.7. So if we compile with java 17, XDocReport should still be compatible with java 8, unless you use the openpdf modules of course, right?
There was a problem hiding this comment.
I added the changes that would be needed to run the tests with jdk17.
There was a problem hiding this comment.
Sorry but the people staying on Java 8 just have to use the old Version of those libraries. For those who keep up to date there should be a release for OpenPDF 2.
You also could make separate Releases for Java 8
There was a problem hiding this comment.
Sorry but the people staying on Java 8 just have to use the old Version of those libraries.
You speak about PDF converter, but XDocReport provides another feature like report generation.
|
This is an excellent improvement, which prepares xdocreport for the modern era in Java development. Please merge this pull request. |
No time to do that, let's move to Java 17. |
|
It seems that there is compilation error https://github.com/opensagres/xdocreport/actions/runs/8649808594/job/24797176532?pr=662#step:4:2072 |
|
@bgoorden CodeQL must be updated to Java 17 here, can you please update this PR: The "Java CI with Maven / build (pull_request)" is succesful. |
|
@bgoorden Please update this PR, thank you. |
|
We still want to compile to java 8 code for now right? |
|
Java 17, please. |
|
There is some build error here, I would appreciate if you would fix this please. |
|
Once ci build wil be fixed we could merge this PR |
|
I'm not getting those build errors on my fork. I updated the maven-bundle-plugin and java version configuration since the error seems to come from there. |
|
LGTM, theCI build is working again, thanksso much @bgoorden ! |
There was already a pullrequest for 2.0.0, but this has some missing changes and failing tests. Since it was not updated for some time I made a new pull request to update to openPDF 2.0.2. (2.0.0 pull request: #636 )
Update to OpenPDF 2.0.2:
#635
OpenPDF require Java 17 or later from version 2.0.0 and later. Before the requirement was java 8.
https://github.com/LibrePDF/OpenPDF/releases/tag/2.0.2 .
I removed the exclusions on bouncycastle. These exclusions are no longer dependencies of openpdf. Also the bouncycastle dependencies that are currently dependencies of openpdf are all optional.