Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate config for ROSA classic #411

Merged

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Nov 7, 2024

https://issues.redhat.com/browse/SRVCOM-3400

  • Generates ROSA classic config for OCP 4.17. Indicated by this config element
  • Removes old configs (4.14 and 4.15) as we generate these custom configs only for one OCP version.
  • Removes also serverless-p2p-rosa-classic config. I have no idea if this is still required. I can put it back if necessary.

This is the config that will be generated after merging this PR: openshift/release#58599

@Sau1506mya
Copy link

/lgtm

Copy link

openshift-ci bot commented Nov 11, 2024

@Sau1506mya: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mgencur mgencur changed the title [WIP] Generate config for ROSA classic Generate config for ROSA classic Nov 11, 2024
@mgencur
Copy link
Contributor Author

mgencur commented Nov 11, 2024

@creydr Hey! This is ready for merging. Thanks

Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

openshift-ci bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgencur, ReToCode, Sau1506mya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f372e80 into openshift-knative:main Nov 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants