Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💝 Dropping redundant variant suffix from test names #414

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cardil
Copy link
Member

@cardil cardil commented Nov 7, 2024

This Pr drops the unnecessary, redundant OCP variant-based suffix. The ci-operator adds the OCP variant at the beginning of the job name, nowadays. Also, all automatically created jobs are AWS-based, so there is no need to put that into the name. There are other jobs that run on other infra than AWS, but they will keep their custom suffix.

This is how job names look like currently:

  • 413-test-e2e-aws-413
  • 413-test-encryption-auth-e2e-aws-413

And this is how they will look:

  • 413-test-e2e
  • 413-test-encryption-auth-e2e

/kind enhancement

@openshift-ci openshift-ci bot added the kind/enhancement New feature or request label Nov 7, 2024
@openshift-ci openshift-ci bot requested review from matzew and mgencur November 7, 2024 16:59
@cardil cardil requested review from pierDipi and removed request for matzew and mgencur November 7, 2024 16:59
Copy link

openshift-ci bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cardil
Once this PR has been reviewed and has the lgtm label, please assign skonto for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant