Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do NOT add OCP variant to custom config names #423

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Nov 13, 2024

I have spoken with INTEROP team and they rely on some automation and processes that need certain naming conventions.

  • Change lp-rosa-classic to ocp4.17-lp-rosa-classic
  • As part of this change - prevent adding the OpenShift variant to the custom config name. It makes sense to hard code the name of the file/variant, i.e. take it directly from the config name. The custom configs often include OCP-specific configuration elements so they're bound to certain OCP version anyway.

Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

openshift-ci bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgencur, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 0c26bed into openshift-knative:main Nov 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants