Add e2e test for broadcast subscription type of resource status update #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morvencao
force-pushed
the
add_e2e_for_broadcast_sub
branch
from
5192e64 to
eac8bd5
Compare
morvencao
force-pushed
the
add_e2e_for_broadcast_sub
branch
3 times, most recently
from
1e79599 to
43ac242
Compare
|
/ok-to-test |
clyang82
reviewed
Jul 1, 2024
.github/workflows/e2e.yml
Outdated
| @@ -23,14 +23,36 @@ jobs: | |||
| uses: actions/setup-go@v5 | |||
| with: | |||
| go-version: ${{ env.GO_VERSION }} | |||
| - name: Setup kind | |||
| uses: engineerd/[email protected] | |||
| # - name: Setup kind | |||
There was a problem hiding this comment.
will it be provided by default?
There was a problem hiding this comment.
The kind binary will be installed using e2e_setup.sh (see: https://github.com/openshift-online/maestro/blob/main/test/e2e/setup/e2e_setup.sh#L20-L25)).
This action sets up a KinD cluster named kind, which is not needed for our purposes. Instead, we will create a KinD cluster named maestro with our own configuration.
morvencao
force-pushed
the
add_e2e_for_broadcast_sub
branch
4 times, most recently
from
48fcd93 to
271a90b
Compare
|
we need to do a rebase for this |
Signed-off-by: morvencao <[email protected]>
morvencao
force-pushed
the
add_e2e_for_broadcast_sub
branch
from
271a90b to
12c6382
Compare
|
rebased the code @qiujian16 |
morvencao
changed the title
morvencao
changed the title
yanmxa
pushed a commit
to yanmxa/maestro
that referenced
this pull request
Jul 9, 2024
…line#137) Signed-off-by: morvencao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an E2E test for scenarios where the MQTT broker doesn't support shared subscriptions, requiring the use of broadcast subscription for the resource status dispatcher.