run maestro with rosa #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skeeey
force-pushed
the
rosa
branch
2 times, most recently
from
dc4a1d0 to
702801c
Compare
clyang82
reviewed
Nov 5, 2024
test/e2e/setup/rosa/README.md
Outdated
| export AWS_IOT_REGION="<your_aws_iot_region>" | ||
| export CLUSTER_REGION="<your_cluster_region>" | ||
| export CLUSTER_VPC="<your_cluster_vpc>" | ||
| export KUBECONFIG="<your_cluster_kubeconfig>" |
There was a problem hiding this comment.
No aws credentials provided? use default location?
There was a problem hiding this comment.
This required a logined aws command
There was a problem hiding this comment.
Add Prerequisites part to address this
|
|
||
| IMAGE_REGISTRY=${IMAGE_REGISTRY:="quay.io/redhat-user-workloads/maestro-rhtap-tenant/maestro"} | ||
| IMAGE_REPOSITORY="maestro" | ||
| IMAGE_TAG=${IMAGE_TAG:-"1de63c6075f2c95c9661d790d164019f60d789f3"} |
There was a problem hiding this comment.
we should get the commit sha via github api
There was a problem hiding this comment.
github api? how to get it?
There was a problem hiding this comment.
this is default value, it can be set outside
test/e2e/setup/rosa/README.md
Outdated
| export AWS_IOT_REGION="<your_aws_iot_region>" | ||
| export CLUSTER_REGION="<your_cluster_region>" | ||
| export CLUSTER_VPC="<your_cluster_vpc>" | ||
| export KUBECONFIG="<your_cluster_kubeconfig>" |
There was a problem hiding this comment.
I saw the next section to create a cluster. what is the purpose for this section?
There was a problem hiding this comment.
this section show how to deploy maestro server and agents in existed clusters
Signed-off-by: Wei Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.