Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OCM-2111] add organization id to feature_review_request type #846

Conversation

ThirumlaDevi
Copy link
Contributor

This PR adds the organization id to the feature_review_request model which is required for ocm-cs integration.
API reference to the feature_review endpoint --> reference

@miguelsorianod
Copy link
Contributor

The change looks good to me 👍 .

I understand from this the next step is that we will generate the changes so they are included in the SDK right?

A minor comment too:

Commit messages should be written in imperative present tense. Avoid using the past or other tenses. The reason for that is that you should see a commit log as a set of steps that if you apply a given commit 'x' will happen.

@lucasponce
Copy link
Collaborator

cc @ciaranRoche or @gdbranco can you please final review and merge?

I don't have rights on this repo

@ThirumlaDevi
Copy link
Contributor Author

Yes @miguelsorianod the request builder from the sdk currently doesn't take this as input which is necessary for ocm cs to migrate to feature review api

@ThirumlaDevi ThirumlaDevi changed the title [OCM-2111] added organization id to feature_review_request type [OCM-2111] add organization id to feature_review_request type Sep 29, 2023
@ThirumlaDevi ThirumlaDevi force-pushed the OCM_2111_added_org_id_to_feature_rev branch from 90d209c to a2f0ee9 Compare September 29, 2023 08:20
Copy link
Contributor

@tzvatot tzvatot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tzvatot tzvatot merged commit 58e82e0 into openshift-online:main Sep 29, 2023
2 checks passed
@ThirumlaDevi
Copy link
Contributor Author

@tzvatot Post merge there is not tag created pointing to this change, could you please trigger the respective github action or please let me know on what i must do from my end to do so?

@tzvatot
Copy link
Contributor

tzvatot commented Sep 29, 2023 via email

@ciaranRoche
Copy link
Collaborator

ill create the tag for you now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants