-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OCM-2111] add organization id to feature_review_request type #846
[OCM-2111] add organization id to feature_review_request type #846
Conversation
The change looks good to me 👍 . I understand from this the next step is that we will generate the changes so they are included in the SDK right? A minor comment too: Commit messages should be written in imperative present tense. Avoid using the past or other tenses. The reason for that is that you should see a commit log as a set of steps that if you apply a given commit 'x' will happen. |
cc @ciaranRoche or @gdbranco can you please final review and merge? I don't have rights on this repo |
Yes @miguelsorianod the request builder from the sdk currently doesn't take this as input which is necessary for ocm cs to migrate to feature review api |
90d209c
to
a2f0ee9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@tzvatot Post merge there is not tag created pointing to this change, could you please trigger the respective github action or please let me know on what i must do from my end to do so? |
It is done manually. See contribution md file I linked on slack.
I'm AFK, but surely some of the other maintainers can create the tag.
…On Fri, Sep 29, 2023, 11:56 Thirumla Devi Sivakumar < ***@***.***> wrote:
@tzvatot <https://github.com/tzvatot> Post merge there is not tag created
pointing to this change, could you please trigger the respective github
action or please let me know on what i must do from my end to do so?
—
Reply to this email directly, view it on GitHub
<#846 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA47PVTCPC7WMG52ZQ3E4ZDX42EKBANCNFSM6AAAAAA5LJH3ZM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
ill create the tag for you now |
This PR adds the organization id to the feature_review_request model which is required for ocm-cs integration.
API reference to the feature_review endpoint --> reference