Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Search parameter to status board product, application, service #854

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

smcavey
Copy link

@smcavey smcavey commented Oct 24, 2023

Add Search parameter to add TSL support to Status Board for [OSDEV-1284]https://issues.redhat.com/browse/OSDEV-1284l) and OSDEV-1281. ocm-sdk-go update

Copy link

@marek-veber marek-veber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ciaranRoche
Copy link
Collaborator

@smcavey can you split the changes into two commits, we want to keep the updates to the changes log in their own commit for the history please 🙏

will merge then

@smcavey
Copy link
Author

smcavey commented Oct 31, 2023

@ciaranRoche Updated, thanks :)

Copy link
Collaborator

@ciaranRoche ciaranRoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ciaranRoche ciaranRoche merged commit d24c179 into openshift-online:main Nov 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants