Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-3852 | feat: Exposed KubeletConfig endpoints and models for day 2 operations of setting PIDs limits #856

Conversation

robpblake
Copy link
Contributor

This PR updates the clusters_mgmt OpenAPI spec to include endpoints and models for managing podPidsLimits as a day 2 operation. In particular this PR:

  • Exposes the /api/clusters_mgmt/v1/clusters/{id}/kubelet_config endpoint and supporting methods
    • GET to read
    • POST to create
    • PATCH to update
    • DELETE to delete
  • Creates the KubeletConfig struct to support the above endpoint
  • Updates the Cluster struct to embed the KubeletConfig struct to allow customers to read details of the KubeletConfig they have applied (if any) via the Cluster resource

@robpblake robpblake marked this pull request as ready for review October 27, 2023 15:12
@robpblake
Copy link
Contributor Author

@ciaranRoche This is ready for review and will unblock the CLI work.

cheers,

Rob

@robpblake robpblake force-pushed the ocm-3852-kubeletconfig-pod-pids-limits branch from fb0fd08 to 9e19b5f Compare November 2, 2023 09:50
Copy link
Collaborator

@ciaranRoche ciaranRoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ciaranRoche ciaranRoche merged commit 2233b00 into openshift-online:main Nov 2, 2023
2 checks passed
@robpblake robpblake deleted the ocm-3852-kubeletconfig-pod-pids-limits branch November 2, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants