GCP CCS command #192
GCP CCS command #192
Conversation
| @@ -75,6 +80,12 @@ func init() { | |||
|
|
|||
| arguments.AddProviderFlag(fs, &args.provider) | |||
| arguments.AddCCSFlags(fs, &args.ccs) | |||
|
|
|||
| fs.Var( | |||
| &args.gcpServiceAccount, | |||
There was a problem hiding this comment.
Ideally declaring this flag would be part of arguments.AddCCSFlags().
One way to do that that might be move the FilePath var inside CCS struct, and making constructGCPCredentials a method on CCS struct. Don't know if worth it.
There was a problem hiding this comment.
Opened #199 for some validations we should improve.
|
Looks great 👍 |
|
|
||
| fs.Var( | ||
| &args.gcpServiceAccount, | ||
| "service-account-file", |
There was a problem hiding this comment.
WDYT about renaming this --gcp-service-account-file? 4 more characters to type but maybe worth it to keep the flags organized.
(BTW, maybe it's time to start using Cobra's flag groups to organize the help 🤔)
| @@ -26,14 +26,33 @@ import ( | |||
| "reflect" | |||
| "strings" | |||
|
|
|||
| "github.com/mattn/go-isatty" | |||
| isatty "github.com/onsi/ginkgo/reporters/stenographer/support/go-isatty" | |||
There was a problem hiding this comment.
@igoihman was this deliberate?
https://github.com/onsi/ginkgo/tree/master/reporters/stenographer/support/go-isatty/
looks like an old, less maintained, copy of upstream https://github.com/mattn/go-isatty/.
Or was this simply replaced by IDE being too clever?
No description provided.