Release v0.1.69 #558
Merged
Release v0.1.69 #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-447488d Added default values for CIDRs and host prefix -672ca8b Fixed CIDR order and added back the comment -fbff80f Fixed the comment statement -1f2b39b fix duplicate machine pool information printed for the same cluster -f0fadd8 add tests for list machinepools command -5b60bbf added failure tests for list machinepools command -498c54e Filtered OCM versions for marketplace gcp clusters -a9f32b7 Changed string pointer to string and removed nil check -0aca318 Changed gcp-marketplace keyword to marketplace-gcp
cristianoveiga
requested changes
Sep 29, 2023
CHANGES.md
Outdated
Comment on lines
14
to
16
| -498c54e Filtered OCM versions for marketplace gcp clusters | ||
| -a9f32b7 Changed string pointer to string and removed nil check | ||
| -0aca318 Changed gcp-marketplace keyword to marketplace-gcp |
There was a problem hiding this comment.
looks like the previous PR got merged without squashing. Can you combine them in something more representative?
There was a problem hiding this comment.
Changed and kept meaningful commit logs in changes.md file
cristianoveiga
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-447488d Added default values for CIDRs and host prefix -672ca8b Fixed CIDR order and added back the comment -fbff80f Fixed the comment statement
-1f2b39b fix duplicate machine pool information printed for the same cluster -f0fadd8 add tests for list machinepools command
-5b60bbf added failure tests for list machinepools command -498c54e Filtered OCM versions for marketplace gcp clusters -a9f32b7 Changed string pointer to string and removed nil check -0aca318 Changed gcp-marketplace keyword to marketplace-gcp