OCM-5281 | Feat | Add region validation from ocm-shards and list regions command #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tirthct
changed the title
macgregor
reviewed
Dec 13, 2023
macgregor
reviewed
Dec 13, 2023
macgregor
reviewed
Dec 13, 2023
macgregor
reviewed
Dec 13, 2023
macgregor
reviewed
Dec 13, 2023
macgregor
reviewed
Dec 13, 2023
macgregor
reviewed
Dec 15, 2023
macgregor
reviewed
Dec 18, 2023
macgregor
reviewed
Dec 18, 2023
macgregor
reviewed
Dec 18, 2023
macgregor
reviewed
Dec 18, 2023
macgregor
reviewed
Dec 18, 2023
macgregor
reviewed
Dec 18, 2023
macgregor
reviewed
Dec 18, 2023
|
lgtm, thanks Tirth! |
|
lgtm |
markturansky
reviewed
Feb 5, 2024
cmd/ocm/list/rhRegion/cmd.go
Outdated
| Use: "rh-regions", | ||
| Short: "List available OCM regions", | ||
| Long: "List available OCM regions", | ||
| Example: ` # List all supported OCM regions ocm list rh-regions`, |
There was a problem hiding this comment.
should this be ocm list rh-regions only?
There was a problem hiding this comment.
Example sections in other files have the same format : https://github.com/openshift-online/ocm-cli/blob/main/cmd/ocm/list/version/cmd.go#L38
There was a problem hiding this comment.
Okay, but IMO that's not really helpful.
| go 1.18 | ||
| go 1.21 |
There was a problem hiding this comment.
is the go version update required here? I'm wondering if it can/should be handled in a separate MR.
There was a problem hiding this comment.
OCM SDK uses latest golang : openshift-online/ocm-sdk-go@1252182#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6
We can create a separate MR here though.
tylercreller
added a commit
to tylercreller/ocm-cli
that referenced
this pull request
Feb 6, 2024
* OCM-4962 | Feat | Add OAuth login using PKCE (openshift-online#590) * OCM-5759 | feat: Add Device Code Flow (openshift-online#591) * OCM-5281 | Feat | Add region validation from ocm-shards and list regions command (openshift-online#586) * Add region validation from ocm-shards and list regions command * Fixed mior debug changes * Marked rh region list flag hidden in cmd * Formatting change in example section in cmd file * OCM-4964: Secure store config * OCM-4964: Go mod tidy * OCM-4964: go mod tidy * OCM-4964: Secure store updates * OCM-4965: Use keyring for oauth flows * Temp: modify pub/release for testing * Add auth method password * Missed auth method test --------- Co-authored-by: tirthct <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
Tested