Introduce gcp WIF sub-commands to manage wif-configs #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renan-campos
reviewed
Jun 3, 2024
ckandag
reviewed
Jun 10, 2024
JakobGray
force-pushed
the
gcp-wif
branch
3 times, most recently
from
b1becc9 to
5cd8d8a
Compare
renan-campos
requested changes
Jun 25, 2024
There was a problem hiding this comment.
This is a large PR, and I did my best to give it a thorough review. I really like the way the code is structured. I numbered the way that I went through the code and the commands. I then looked at the helper files in the order github has them. I think some discussion is needed on some points, which we can do tomorrow during the usual sync.
ckandag
reviewed
Jun 27, 2024
ckandag
reviewed
Jun 27, 2024
JakobGray
changed the title
renan-campos
requested changes
Jun 27, 2024
renan-campos
approved these changes
Jun 28, 2024
ckandag
added a commit
that referenced
this pull request
Aug 8, 2024
-416843e OSD-24332 Adding CNI Type to the printed output. -ca71863 Introduce gcp WIF sub-commands to manage wif-configs (#619) -5f9697b multi arch release images (#631) -951d7cd Red Hat Konflux update ocm-cli (#633) -2604647 Limit Konflux Pipeline Runs (#634) -9645301 Update Konflux references (#635) -c797dfb Update Konflux references to 0dc3087 -28b521d support hermetic build (#636) -3117d6b Update Konflux references to 9eee3cf -d228140 Update Konflux references to 71270c3 -0ff233b update konflux pipeline (#641) -ae2093b Update Konflux references -2ae4aa0 Update Konflux references -bdd172b Update Konflux references to f93024e -d750acc Red Hat Konflux update ocm-cli Signed-off-by: red-hat-konflux <[email protected]> -0bbcf6e Update Konflux references -21ff6b8 Replace wif models and client with sdk (#643) -c3d52e2 Update Konflux build (#651) -8073ef8 release_version (#652) -e9a014d Update Konflux references -78317e9 Add 'wif-config' flag as cluster create option -49f4e41 Set project number on wif config creation -e441c1b Update Konflux references -ca8d9db Support listing and parameters in 'gcp get wif-config' (#656)
ckandag
added a commit
that referenced
this pull request
Aug 8, 2024
-416843e OSD-24332 Adding CNI Type to the printed output. -ca71863 Introduce gcp WIF sub-commands to manage wif-configs (#619) -5f9697b multi arch release images (#631) -951d7cd Red Hat Konflux update ocm-cli (#633) -2604647 Limit Konflux Pipeline Runs (#634) -9645301 Update Konflux references (#635) -c797dfb Update Konflux references to 0dc3087 -28b521d support hermetic build (#636) -3117d6b Update Konflux references to 9eee3cf -d228140 Update Konflux references to 71270c3 -0ff233b update konflux pipeline (#641) -ae2093b Update Konflux references -2ae4aa0 Update Konflux references -bdd172b Update Konflux references to f93024e -d750acc Red Hat Konflux update ocm-cli Signed-off-by: red-hat-konflux <[email protected]> -0bbcf6e Update Konflux references -21ff6b8 Replace wif models and client with sdk (#643) -c3d52e2 Update Konflux build (#651) -8073ef8 release_version (#652) -e9a014d Update Konflux references -78317e9 Add 'wif-config' flag as cluster create option -49f4e41 Set project number on wif config creation -e441c1b Update Konflux references -ca8d9db Support listing and parameters in 'gcp get wif-config' (#656)
Merged
renan-campos
pushed a commit
that referenced
this pull request
Aug 8, 2024
-416843e OSD-24332 Adding CNI Type to the printed output. -ca71863 Introduce gcp WIF sub-commands to manage wif-configs (#619) -5f9697b multi arch release images (#631) -951d7cd Red Hat Konflux update ocm-cli (#633) -2604647 Limit Konflux Pipeline Runs (#634) -9645301 Update Konflux references (#635) -c797dfb Update Konflux references to 0dc3087 -28b521d support hermetic build (#636) -3117d6b Update Konflux references to 9eee3cf -d228140 Update Konflux references to 71270c3 -0ff233b update konflux pipeline (#641) -ae2093b Update Konflux references -2ae4aa0 Update Konflux references -bdd172b Update Konflux references to f93024e -d750acc Red Hat Konflux update ocm-cli Signed-off-by: red-hat-konflux <[email protected]> -0bbcf6e Update Konflux references -21ff6b8 Replace wif models and client with sdk (#643) -c3d52e2 Update Konflux build (#651) -8073ef8 release_version (#652) -e9a014d Update Konflux references -78317e9 Add 'wif-config' flag as cluster create option -49f4e41 Set project number on wif config creation -e441c1b Update Konflux references -ca8d9db Support listing and parameters in 'gcp get wif-config' (#656)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces sub-commands for workload identity federation under a new gcp command:
ocm gcp create wif-config --name=<name> --project=<project>ocm gcp delete wif-config <id>ocm gcp get wif-config <id>ocm gcp list wif-configocm gcp describe wif-config <id>ocm gcp update wif-config <id>[unimplemented]ocm gcp generate <id>These commands allow users to prepare and manage workload identity configurations in order to deploy clusters using the new method