OCM-12971 | 'ocm gcp update wif-config' remediates all wif-config misconfigurations #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckandag
reviewed
Dec 12, 2024
ckandag
reviewed
Dec 12, 2024
ckandag
reviewed
Dec 12, 2024
ckandag
reviewed
Dec 12, 2024
ckandag
reviewed
Dec 12, 2024
renan-campos
force-pushed
the
OCM-12971
branch
from
dc439d0 to
2ff3278
Compare
ckandag
approved these changes
Dec 12, 2024
JakobGray
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The following new behavior was added to the functionality of the command used to update resources associated with wif-configs:
Testing
The resources of a test wif-config resource was manually modified into the states described above. Running
ocm gcp verify wif-configconfirmed that the error related to the misconfiguration was detected. After runningocm gcp update wif-config, verification succeeds. Manual inspection of GCP resources confirms that their configuration was corrected through calling the update command.