This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Add domain attribute to cluster_rosa_classic resource #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dns.base_domain
attribute is immediately available from the API when creating a new cluster, and can be useful in further configuration of resources within the same terraform run.This value can be queried using
rosa describe cluster -c id
. The value from the ROSA CLI is always[name].[dns.base_domain]
, which is why the domain attribute prepends the cluster name in this proposed feature.An example use would be configuring an OpenID IdP using the domain attribute for the callback URL.
This creates a nice workflow where the cluster creation can begin in the background (required already because of the OIDC Provider dependency), and the
ocm_identity_provider
of type OpenID can be created in the same terraform run, which will trigger the wait for cluster install completion loop onocm_identity_provider
.The result is a single terraform run for a ROSA cluster build, that does not exit until the cluster is ready for use, with SSO login enabled.