Update version command to get version of particular component #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pratap0007
force-pushed
the
opc-version-command
branch
from
8b8e351
to
4d9e6d7
Compare
This patch adds flag `component` to get the version of a particular component and also version command show available component versions Signed-off-by: Shiv Verma <[email protected]>
pratap0007
force-pushed
the
opc-version-command
branch
from
4d9e6d7
to
18be3d7
Compare
chmouel
reviewed
May 31, 2023
| return fmt.Errorf("unknown component: %v", args[1]) | ||
| } | ||
| if args[0] == "pac" { | ||
| fmt.Fprintf(cmd.OutOrStdout(), "%s\n", v.Opc) |
There was a problem hiding this comment.
you should be able to get the pac version from runtime as cli
chmouel
reviewed
May 31, 2023
|
closing this PR as there is better implementation in this PR #161 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds flag
componentto get theversion of a particular component and also
version command show available component versions