Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add omitempty tag for imageStreamImportMode #2070

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Oct 17, 2024

This seems to match the original proposal https://github.com/openshift/enhancements/pull/1605/files#diff-c3558e7ce5705e060c3f6ccbbf7430be6fe4dac2b8bad05220360bd977f81e70R214, recomendations and consistency with the rest of this API. The reason I came across this is that hypershift seralizes this API and use that as input to generate a hash that now transparently changes. While that fundamental problem is solved this will happen to buy hypershift some time.

This seems to match the original proposal https://github.com/openshift/enhancements/pull/1605/files#diff-c3558e7ce5705e060c3f6ccbbf7430be6fe4dac2b8bad05220360bd977f81e70R214, recomendations and consistency with the rest of this API.
The reason I came across this is that hypershift seralizes this API and use that as input to generate a hash that now transparently changes. While that fundamental problem is solved this will happen to buy hypershift some time.
Copy link
Contributor

openshift-ci bot commented Oct 17, 2024

Hello @enxebre! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 17, 2024
@openshift-ci openshift-ci bot requested review from bparees and sjenning October 17, 2024 20:13
Copy link
Contributor

openshift-ci bot commented Oct 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: enxebre
Once this PR has been reviewed and has the lgtm label, please assign knobunc for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Dec 4, 2024

@enxebre: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant