Add changes to infrastructure object to contain service endpoints and feature flag added #2078
Conversation
|
Hello @jared-hayes-dev! Some important instructions when contributing to openshift/api: |
openshift-ci
bot
added
the
size/S
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jared-hayes-dev The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
size/M
config/v1/types_infrastructure.go
Outdated
| // ServiceEndpoints contains custom endpoints designated to | ||
| // override existing defaults of IBM Cloud Services. |
There was a problem hiding this comment.
The godoc on the status version of this field is different, shall we copy it here?
config/v1/types_infrastructure.go
Outdated
| type IBMCloudPlatformSpec struct { | ||
| // ServiceEndpoints contains custom endpoints designated to | ||
| // override existing defaults of IBM Cloud Services. | ||
| // +listType=atomic |
There was a problem hiding this comment.
Status version is a map type, why would this one be different?
There was a problem hiding this comment.
my bad, unintentionally messed that up when playing with some things - fixed
| @@ -670,4 +670,10 @@ var ( | |||
| enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade). | |||
| enhancementPR("https://github.com/openshift/enhancements/pull/1697"). | |||
| mustRegister() | |||
|
|
|||
| FeatureGateDyanmicServiceEndpointIBMCloud = newFeatureGate("DyanmicServiceEndpointIBMCloud"). | |||
There was a problem hiding this comment.
You'll want to include an enableIn and add this to DevPreview and TechPreview initially
| type IBMCloudPlatformSpec struct { | ||
| // serviceEndpoints is a list of custom endpoints which will override the default | ||
| // service endpoints of an IBM Cloud service. These endpoints are consumed by | ||
| // components within the cluster to reach the respective IBM Cloud Services. |
There was a problem hiding this comment.
I think we should add some description here of what happens when you add values. They get verified and then copied to status by some controller right? And then consumed by?
|
@jared-hayes-dev: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Related Jira: https://issues.redhat.com/browse/OCPCLOUD-2694