Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NE-1871: Promote GatewayAPI to Tech Preview #2081

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rfredette
Copy link
Contributor

@rfredette rfredette commented Oct 31, 2024

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2024
Copy link
Contributor

openshift-ci bot commented Oct 31, 2024

Hello @rfredette! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 31, 2024
Copy link
Contributor

openshift-ci bot commented Oct 31, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rfredette
Once this PR has been reviewed and has the lgtm label, please assign derekwaynecarr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rfredette rfredette changed the title WIP: Promote GatewayAPI to Tech Preview NE-1871: Promote GatewayAPI to Tech Preview Nov 4, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 4, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 4, 2024

@rfredette: This pull request references NE-1871 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 4, 2024
@rfredette
Copy link
Contributor Author

test failures seem unrelated
/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 4, 2024

@rfredette: This pull request references NE-1871 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Enhancement: Gateway API with Cluster Ingress Operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rfredette
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 4, 2024

@rfredette: This pull request references NE-1871 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rfredette
Copy link
Contributor Author

Until the Gateway API feature is ready to be considered tech preview:
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2024
@candita
Copy link
Contributor

candita commented Nov 13, 2024

/assign @gcs278
/assign @Thealisyed

@candita
Copy link
Contributor

candita commented Nov 18, 2024

@gcs278 @rfredette based on our team meeting this morning, we would like to pursue merging this so Gateway API integration can get the CI exercise that a TechPreview cluster gets, on all platforms. Can you please unhold and review so we can make that happen?

@gcs278
Copy link
Contributor

gcs278 commented Nov 18, 2024

@gcs278 @rfredette based on our team meeting this morning, we would like to pursue merging this so Gateway API integration can get the CI exercise that a TechPreview cluster gets, on all platforms. Can you please unhold and review so we can make that happen?

@candita maybe I misunderstood, but I thought the decision was to wait until 4.19 branch opens to bump the feature gate to Tech Preview. In 4.19, we'd would do Dev Preview --> Tech Preview --> GA, all in the same development cycle.

@candita
Copy link
Contributor

candita commented Nov 18, 2024

@gcs278 @rfredette based on our team meeting this morning, we would like to pursue merging this so Gateway API integration can get the CI exercise that a TechPreview cluster gets, on all platforms. Can you please unhold and review so we can make that happen?

@candita maybe I misunderstood, but I thought the decision was to wait until 4.19 branch opens to bump the feature gate to Tech Preview. In 4.19, we'd would do Dev Preview --> Tech Preview --> GA, all in the same development cycle.

No, it's better for us to do this without having to backport it after branch cut if possible.

Copy link
Contributor

openshift-ci bot commented Dec 4, 2024

@rfredette: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-hypershift b9afb68 link true /test e2e-aws-ovn-hypershift
ci/prow/lint b9afb68 link true /test lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 4, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gcs278
Copy link
Contributor

gcs278 commented Dec 19, 2024

@candita @rfredette I think we are ready to proceed with this PR now that 4.18 branch cut has happened based on our conversation in slack. We'll have to wait until after the holidays to merge, but following up here before I forget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants