-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NE-1871: Promote GatewayAPI to Tech Preview #2081
base: master
Are you sure you want to change the base?
Conversation
Hello @rfredette! Some important instructions when contributing to openshift/api: |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rfredette The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rfredette: This pull request references NE-1871 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
test failures seem unrelated |
@rfredette: This pull request references NE-1871 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@rfredette: This pull request references NE-1871 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Until the Gateway API feature is ready to be considered tech preview: |
/assign @gcs278 |
@gcs278 @rfredette based on our team meeting this morning, we would like to pursue merging this so Gateway API integration can get the CI exercise that a TechPreview cluster gets, on all platforms. Can you please unhold and review so we can make that happen? |
@candita maybe I misunderstood, but I thought the decision was to wait until 4.19 branch opens to bump the feature gate to Tech Preview. In 4.19, we'd would do Dev Preview --> Tech Preview --> GA, all in the same development cycle. |
No, it's better for us to do this without having to backport it after branch cut if possible. |
@rfredette: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@candita @rfredette I think we are ready to proceed with this PR now that 4.18 branch cut has happened based on our conversation in slack. We'll have to wait until after the holidays to merge, but following up here before I forget. |
Enhancement: Gateway API with Cluster Ingress Operator