Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-45888: ClusterNetworkOperator API: promote the additionalRoutingCapabilities flag to default #2119

Open
wants to merge 1 commit into
base: release-4.18
Choose a base branch
from

Conversation

fedepaol
Copy link
Member

@fedepaol fedepaol commented Dec 6, 2024

Promoting the feature gate as the deployed daemonset is being used by metallb and covered by MetalLB tests.

Backport of #2087

… gate

Promoting the feature gate as the deployed daemonset is being used by
metallb and covered by MetalLB tests.

Signed-off-by: Federico Paolinelli <[email protected]>
Copy link
Contributor

openshift-ci bot commented Dec 6, 2024

Hello @fedepaol! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 6, 2024
Copy link
Contributor

openshift-ci bot commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fedepaol
Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fedepaol
Copy link
Member Author

fedepaol commented Dec 9, 2024

/retest

@fedepaol fedepaol changed the title ClusterNetworkOperator API: promote the additionalRoutingCapabilities fg ClusterNetworkOperator API: promote the additionalRoutingCapabilities flag to default Dec 9, 2024
@fedepaol
Copy link
Member Author

fedepaol commented Dec 9, 2024

/jira backport OCPBUGS-45887

@openshift-ci-robot
Copy link

@fedepaol: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick OCPBUGS-45887

In response to this:

/jira backport OCPBUGS-45887

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@openshift-ci-robot: once the present PR merges, I will cherry-pick it on top of OCPBUGS-45887 in a new PR and assign it to you.

In response to this:

@fedepaol: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick OCPBUGS-45887

In response to this:

/jira backport OCPBUGS-45887

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fedepaol
Copy link
Member Author

fedepaol commented Dec 9, 2024

/jira cherry-pick OCPBUGS-45887

@openshift-ci-robot
Copy link

@fedepaol: Jira Issue OCPBUGS-45887 has been cloned as Jira Issue OCPBUGS-45888. Will retitle bug to link to clone.
/retitle OCPBUGS-45888: ClusterNetworkOperator API: promote the additionalRoutingCapabilities flag to default

In response to this:

/jira cherry-pick OCPBUGS-45887

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title ClusterNetworkOperator API: promote the additionalRoutingCapabilities flag to default OCPBUGS-45888: ClusterNetworkOperator API: promote the additionalRoutingCapabilities flag to default Dec 9, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 9, 2024
@openshift-ci-robot
Copy link

@fedepaol: This pull request references Jira Issue OCPBUGS-45888, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-45887 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is Closed (Done) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Promoting the feature gate as the deployed daemonset is being used by metallb and covered by MetalLB tests.

Backport of #2087

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@fedepaol
Copy link
Member Author

fedepaol commented Dec 9, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 9, 2024
@openshift-ci-robot
Copy link

@fedepaol: This pull request references Jira Issue OCPBUGS-45888, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-45887 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-45887 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@fedepaol
Copy link
Member Author

fedepaol commented Dec 9, 2024

cc @JoelSpeed

Copy link
Contributor

openshift-ci bot commented Dec 9, 2024

@fedepaol: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-crd-schema 7bf123b link true /test verify-crd-schema
ci/prow/okd-scos-e2e-aws-ovn 7bf123b link false /test okd-scos-e2e-aws-ovn
ci/prow/verify 7bf123b link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

@fedepaol Can you please go through the bug process and make sure that we have a valid bug chain. Is there feature now complete in 4.19, and verified by QE? We cannot start the backport process until we are happy that everything is complete in 4.19

@fedepaol
Copy link
Member Author

fedepaol commented Dec 9, 2024

@fedepaol Can you please go through the bug process and make sure that we have a valid bug chain. Is there feature now complete in 4.19, and verified by QE? We cannot start the backport process until we are happy that everything is complete in 4.19

Ok, will do.

@fedepaol
Copy link
Member Author

fedepaol commented Dec 9, 2024

/jira refresh

@openshift-ci-robot
Copy link

@fedepaol: This pull request references Jira Issue OCPBUGS-45888, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-45887 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-45887 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants