Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo: update to latest env_logger (0.6.0) #33

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

lucab
Copy link
Contributor

@lucab lucab commented Jan 2, 2019

No description provided.

@app-sre-bot
Copy link

Can one of the admins verify this patch?

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 2, 2019
@crawford
Copy link
Contributor

crawford commented Jan 2, 2019

Tests failed with the following:

error: open /tmp/build/inputs/dist/openshift-release/Dockerfile.builder: no such file or directory

/cc @steveej

@steveej
Copy link
Contributor

steveej commented Jan 2, 2019

The prow failure is currently expected as the prow job depends on files introduced in #11.

I wonder why the app-sre CI isn't triggered for this PR though. @riuvshin any ideas why that is?

@steveej
Copy link
Contributor

steveej commented Jan 2, 2019

[test]

@steveej
Copy link
Contributor

steveej commented Jan 2, 2019

Thanks @lucab!

/approve

@steveej
Copy link
Contributor

steveej commented Jan 2, 2019

The approval also depends on the OWNERS file introduced in #34.

@steveej
Copy link
Contributor

steveej commented Jan 7, 2019

/test cargo-test

@steveej
Copy link
Contributor

steveej commented Jan 7, 2019

/approve
/lgtm

@lucab lucab force-pushed the ups/deps-env_logger branch from 17f438d to 399cd02 Compare January 7, 2019 21:08
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2019
@lucab lucab force-pushed the ups/deps-env_logger branch from 399cd02 to 2ef8b11 Compare January 7, 2019 22:08
@steveej
Copy link
Contributor

steveej commented Jan 8, 2019

/approve

@steveej
Copy link
Contributor

steveej commented Jan 8, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucab, steveeJ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b6feb6e into openshift:master Jan 8, 2019
@lucab lucab deleted the ups/deps-env_logger branch April 24, 2019 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants