-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Bp and re-generate test harness #346
base: master
Are you sure you want to change the base?
Conversation
/retest |
1 similar comment
/retest |
/hold we should not merge this until the boilerplate incident is resolved (this bumps the base image to v5.0.2 which is a bad version) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #346 +/- ##
=======================================
Coverage 41.14% 41.14%
=======================================
Files 26 26
Lines 2615 2615
=======================================
Hits 1076 1076
Misses 1459 1459
Partials 80 80
|
51e0042
to
e8e9b96
Compare
/test lint |
e8e9b96
to
15150ea
Compare
/hold cancel |
15150ea
to
1f0076b
Compare
@YiqinZhang: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @YiqinZhang!
/lgtm
/approve
/hold |
/unhold |
/lgtm |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: abyrne55, YiqinZhang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
boilerplate update
make boilerplate-update
test harness re-generate - uses new osde2e image
make e2e-harness-generate
SDCICD-1415