Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bp and re-generate test harness #346

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

YiqinZhang
Copy link

@YiqinZhang YiqinZhang commented Oct 29, 2024

  • boilerplate update
    make boilerplate-update

  • test harness re-generate - uses new osde2e image
    make e2e-harness-generate

SDCICD-1415

@jbpratt
Copy link

jbpratt commented Oct 29, 2024

/retest

1 similar comment
@jbpratt
Copy link

jbpratt commented Oct 29, 2024

/retest

@jbpratt
Copy link

jbpratt commented Oct 29, 2024

/hold

we should not merge this until the boilerplate incident is resolved (this bumps the base image to v5.0.2 which is a bad version)

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.14%. Comparing base (3420c2a) to head (1f0076b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #346   +/-   ##
=======================================
  Coverage   41.14%   41.14%           
=======================================
  Files          26       26           
  Lines        2615     2615           
=======================================
  Hits         1076     1076           
  Misses       1459     1459           
  Partials       80       80           
---- 🚨 Try these New Features:

@YiqinZhang
Copy link
Author

/test lint
/test validate

@YiqinZhang
Copy link
Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2024
Copy link
Contributor

openshift-ci bot commented Nov 19, 2024

@YiqinZhang: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

@abyrne55 abyrne55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @YiqinZhang!

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2024
@jbpratt
Copy link

jbpratt commented Nov 25, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2024
@jbpratt
Copy link

jbpratt commented Nov 26, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 26, 2024
@YiqinZhang YiqinZhang requested a review from abyrne55 November 26, 2024 16:01
@abyrne55
Copy link

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Nov 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abyrne55, YiqinZhang
Once this PR has been reviewed and has the lgtm label, please assign boranx for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants