OpenStack: Image name validations #2492
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
size/XXL
Fedosin
force-pushed
the
image_name_validations
branch
from
8da7fdf to
237ac4b
Compare
openshift-ci-robot
added
size/M
Fedosin
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/hold cancel |
Fedosin
force-pushed
the
image_name_validations
branch
from
237ac4b to
126d03c
Compare
|
/retest |
|
/label platform/openstack |
|
@jstuever: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
requested review from
mandre and
tomassedovic
and removed request for
jstuever
|
/label platform/openstack |
|
/lgtm |
pkg/rhcos/openstack.go
Outdated
| @@ -41,3 +43,39 @@ func GenerateOpenStackImageName(rhcosImage, infraID string) (imageName string, i | |||
|
|
|||
| return infraID + "-rhcos", true | |||
| } | |||
|
|
|||
| // ValidateOverriddenOpenStackImageName checks if an overridden image name exists and there are no other images with this name. | |||
| func ValidateOverriddenOpenStackImageName(imageName, cloud string) error { | |||
There was a problem hiding this comment.
please move this to pkg/tfvars/openstack, that seems like the best place for this.
Also would like to recommend this be private function and not part of the package API
If the user provides an overridden Glance image name then we need to validate that this image exists and there are no other images with this name.
Fedosin
force-pushed
the
image_name_validations
branch
from
126d03c to
a165e24
Compare
openshift-ci-robot
added
approved
|
/test e2e-aws |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fedosin, mandre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
When the image is provided by user, i.e. not created automatically by the installer, we need to check that the image exists and there are no other images with this name.