Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fcos] Support Ignition3 and FCOS #2548

Merged
merged 26 commits into from
Nov 12, 2019
Merged

[fcos] Support Ignition3 and FCOS #2548

merged 26 commits into from
Nov 12, 2019

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented Oct 22, 2019 •
edited
Loading

Initial PR for OKD-on-FCOS installation.

  • Switch to go modules so that Ignition spec3 implementation could be used.
    Note that I had to rip out Azure support as it was incompatible with terraform
  • Point AWS images to FCOS official AMIs
  • Run pivot from oscontainer early in the bootstrap process
    This increases install time but ensures the latest crio/podman/kubelet are used during bootstrap process so that Fedora would not have to maintain a new stream with openshift bits
  • Force-enable Hyperthreading - see Policy for disabling SMT coreos/fedora-coreos-tracker#181

TODO:

  • Bring back Azure (can be postponed)
  • Update links in rhcos.json to point to Fedora CoreOS
  • Fix unittests and go vet (vendor things again?)

Nevermind the release image - these would be replaced later once Prow would generate a proper release.

cc @LorbusChris @smarterclayton

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 22, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2019
@vrutkovs vrutkovs force-pushed the okd branch 2 times, most recently from de1d2b1 to 7d4249f Compare October 24, 2019 12:52
@LorbusChris LorbusChris mentioned this pull request Oct 24, 2019
Closed
@vrutkovs vrutkovs force-pushed the okd branch 5 times, most recently from 3988835 to a129893 Compare October 24, 2019 21:45
@vrutkovs vrutkovs force-pushed the okd branch 3 times, most recently from c016b48 to 2a859f7 Compare October 25, 2019 09:29
@vrutkovs vrutkovs changed the base branch from master-fcos to fcos October 29, 2019 17:37
@vrutkovs vrutkovs changed the title [master-fcos] Support Ignition3 and FCOS [fcos] Support Ignition3 and FCOS Oct 29, 2019
@LorbusChris
Copy link
Member

/retest

4 similar comments
@vrutkovs
Copy link
Member Author

vrutkovs commented Nov 3, 2019

/retest

@vrutkovs
Copy link
Member Author

vrutkovs commented Nov 3, 2019

/retest

@vrutkovs
Copy link
Member Author

vrutkovs commented Nov 4, 2019

/retest

@vrutkovs
Copy link
Member Author

vrutkovs commented Nov 4, 2019

/retest

@vrutkovs
Copy link
Member Author

vrutkovs commented Nov 5, 2019

Setup passes, a few FCOS fixes are required to pass e2e tests

@vrutkovs
Copy link
Member Author

vrutkovs commented Nov 7, 2019

/retest

1 similar comment
@vrutkovs
Copy link
Member Author

vrutkovs commented Nov 9, 2019

/retest

@vrutkovs
Copy link
Member Author

vrutkovs commented Nov 9, 2019

port-forwarding tests are now fixed, waiting for fixed nfs-utils-coreos to land in FCOS testing-devel

@vrutkovs
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 12, 2019 •
edited
Loading

@vrutkovs: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-openstack 71853fcd43519576855e1a0f0f1190d24f672bd0 link /test e2e-openstack
ci/prow/e2e-aws-scaleup-rhel7 71853fcd43519576855e1a0f0f1190d24f672bd0 link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-libvirt 71853fcd43519576855e1a0f0f1190d24f672bd0 link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs vrutkovs mentioned this pull request Nov 12, 2019
Closed
@vrutkovs
Copy link
Member Author

/retest

@smarterclayton
Copy link
Contributor

Consider this branch specific to fcos, is there a variant of this opened for all included commits for master?

@LorbusChris
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2019
@vrutkovs
Copy link
Member Author

I don't think there is, I was syncing we'd do sync PRs from time to time

@LorbusChris
Copy link
Member

/lgtm cancel

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2019
@smarterclayton
Copy link
Contributor

So these commits are "throw away" and someone else will be doing ignition 3.0 and go.mod support?

@vrutkovs
Copy link
Member Author

Its likely that these are throwaway, yes, if there is a better way to restructure the codebase.

At this point it doesn't make much sense to create PR back to master:

@smarterclayton
Copy link
Contributor

And go.mod?

@smarterclayton
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [smarterclayton,vrutkovs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrutkovs
Copy link
Member Author

go.mod might make it into the master (this PR has both ign3 switch and go.mod, since ign3 requires go.mod). go.mod switch has broken Azure though, but I'm sure it can be sorted out

@openshift-merge-robot openshift-merge-robot merged commit 23f4029 into openshift:fcos Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

Assignees

@smarterclayton smarterclayton

@LorbusChris LorbusChris

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@vrutkovs @squeed @LorbusChris @openshift-ci-robot @smarterclayton @openshift-merge-robot @Fedosin @cgwalters