Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP [FCOS] rhcos.json: use FCOS image for GCP #2882

Closed
wants to merge 37 commits into from

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented Jan 6, 2020

Update GCP image location

TODO:

vrutkovs and others added 30 commits October 24, 2019 20:49
[fcos] Add vrutkovs and LorbusChris to OWNERS
This PR updated the current building system and ci images from
golang 1.10 to 1.12.
Rather than doing a `systemctl restart crio` after `kubelet.service`
has started, separate out the bit that changes the pause image
into a small separate service.
The kubelet template in the MCO should be considered canonical.
We want the crio.service dependencies in particular.
If one of these commands happens to exit with an error,
we don't want to blindly stumble on.

Furthermore, `-u` helps guard against typos.

http://redsymbol.net/articles/unofficial-bash-strict-mode/
[fcos] Support Ignition3 and FCOS
…rvice

This simplifies debugging when MCD image is being pulled
vrutkovs and others added 7 commits December 11, 2019 19:18
This would ensure CRIO's bootstrap would use FCOS-compatible hooks dir.

PR openshift/machine-config-operator#1311 would 
do the same for masters and workers
…trap

[FCOS] bootstrap: replace CRIO's hooks dir on bootstrap
[FCOS] install-masters-gather: gather logs for machine-config-daemon-pull
[FCOS] bootstrap: disable zincati on bootstrap
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 6, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign vrutkovs
You can assign the PR to them by writing /assign @vrutkovs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Rikbruggink
Copy link

@vrutkovs GCP doesnt support images on locations outside of GCP. FCOS needs to be available in GCP or we need to build in support for uploading a custom image to a bucket in gcp and use that image.

@vrutkovs
Copy link
Member Author

Ooh, I see, we're gonna have to wait for official release then

@openshift-ci-robot
Copy link
Contributor

@vrutkovs: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2020
@openshift-ci-robot
Copy link
Contributor

@vrutkovs: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify-vendor d23c21c link /test verify-vendor
ci/prow/e2e-aws d23c21c link /test e2e-aws
ci/prow/e2e-vsphere d23c21c link /test e2e-vsphere
ci/prow/yaml-lint d23c21c link /test yaml-lint
ci/prow/shellcheck d23c21c link /test shellcheck

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs vrutkovs closed this Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants