-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP [FCOS] rhcos.json: use FCOS image for GCP #2882
Conversation
[fcos] Add vrutkovs and LorbusChris to OWNERS
…pivot before proceeding
This PR updated the current building system and ci images from golang 1.10 to 1.12.
Rather than doing a `systemctl restart crio` after `kubelet.service` has started, separate out the bit that changes the pause image into a small separate service.
The kubelet template in the MCO should be considered canonical. We want the crio.service dependencies in particular.
If one of these commands happens to exit with an error, we don't want to blindly stumble on. Furthermore, `-u` helps guard against typos. http://redsymbol.net/articles/unofficial-bash-strict-mode/
[fcos] Support Ignition3 and FCOS
…rvice This simplifies debugging when MCD image is being pulled
This would ensure CRIO's bootstrap would use FCOS-compatible hooks dir. PR openshift/machine-config-operator#1311 would do the same for masters and workers
…trap [FCOS] bootstrap: replace CRIO's hooks dir on bootstrap
[FCOS] install-masters-gather: gather logs for machine-config-daemon-pull
[FCOS] bootstrap: disable zincati on bootstrap
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@vrutkovs GCP doesnt support images on locations outside of GCP. FCOS needs to be available in GCP or we need to build in support for uploading a custom image to a bucket in gcp and use that image. |
Ooh, I see, we're gonna have to wait for official release then |
@vrutkovs: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@vrutkovs: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Update GCP image location
TODO: