Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.6] Bug 1945544: templates: add After=ostree-finalize-staged.service to kubelet.service #2502

Merged
merged 1 commit into from
May 7, 2021
Merged

[release-4.6] Bug 1945544: templates: add After=ostree-finalize-staged.service to kubelet.service #2502

merged 1 commit into from
May 7, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2455

/assign yuqi-zhang

@jlebon
templates: add After=ostree-finalize-staged.service to kubelet.service
d266aa2 
We've seen occasional issues during upgrades caused by what seems to be
the kubelet still being active during OSTree finalization. If the
kubelet changes things in `/etc`, it'll confuse OSTree which is trying
to do the `/etc` merge.

We want to be sure that the kubelet is done modifying everything it
needs to in `/etc` and that it exited before we finalize the deployment.

Add a `After=ostree-finalize-staged.service` for this. The way this
works is that that service runs in its `ExecStop`, and shutdown ordering
is the reverse of startup. So this will cause the kubelet to exit before
`ostree-finalize-staged.service` is stopped.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1902963
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 30, 2021
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: An error was encountered cloning bug for cherrypick for bug 1936008 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. response code 502 not 200

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

[release-4.6] [release-4.7] Bug 1936008: templates: add After=ostree-finalize-staged.service to kubelet.service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kikisdeliveryservice kikisdeliveryservice changed the title [release-4.6] [release-4.7] Bug 1936008: templates: add After=ostree-finalize-staged.service to kubelet.service [release-4.6] Bug 1936008: templates: add After=ostree-finalize-staged.service to kubelet.service Mar 31, 2021
@kikisdeliveryservice
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 31, 2021
@openshift-ci-robot
Copy link
Contributor

@kikisdeliveryservice: This pull request references Bugzilla bug 1936008, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to target the "4.6.z" release, but it targets "4.7.z" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (ERRATA) instead
  • expected dependent Bugzilla bug 1902963 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kikisdeliveryservice
Copy link
Contributor

/skip

@kikisdeliveryservice
Copy link
Contributor

something wrong with the bz on this one..

@sinnykumari sinnykumari changed the title [release-4.6] Bug 1936008: templates: add After=ostree-finalize-staged.service to kubelet.service [release-4.6] Bug 1945544: templates: add After=ostree-finalize-staged.service to kubelet.service Apr 1, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 1, 2021
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1945544, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1936008 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1936008 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

Requesting review from QA contact:
/cc @mike-nguyen

In response to this:

[release-4.6] Bug 1945544: templates: add After=ostree-finalize-staged.service to kubelet.service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sinnykumari
Copy link
Contributor

looks like bot didn't create corresponding 4.6 BZ. Created one.

@sinnykumari
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 1, 2021
@jlebon
Copy link
Member

jlebon commented Apr 13, 2021

How do we get approval for this? I think this may help with https://bugzilla.redhat.com/show_bug.cgi?id=1915225 (see https://bugzilla.redhat.com/show_bug.cgi?id=1915225#c8).

@yuqi-zhang
Copy link
Contributor

This just needs the cherry-pick-approved label, which requires a patch manager to explicitly approve for the next 4.6 release. It is mostly out of our hands unless we wish to escalate its priority (via bugzilla or elsewise)

@mfojtik
Copy link
Contributor

mfojtik commented Apr 15, 2021

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

  • Score: 0.20
  • Reason: maximum total for this z-stream is 10

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

@knobunc knobunc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 6, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 6, 2021 •
edited
Loading

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/okd-e2e-upgrade d266aa2 link /test okd-e2e-upgrade
ci/prow/okd-e2e-gcp-op d266aa2 link /test okd-e2e-gcp-op

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6eca4bd into openshift:release-4.6 May 7, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 7, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1945544 has been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1945544: templates: add After=ostree-finalize-staged.service to kubelet.service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rphillips rphillips Awaiting requested review from rphillips

@sjenning sjenning Awaiting requested review from sjenning

@mike-nguyen mike-nguyen Awaiting requested review from mike-nguyen

Assignees

@sinnykumari sinnykumari

@yuqi-zhang yuqi-zhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@openshift-cherrypick-robot @openshift-ci-robot @kikisdeliveryservice @sinnykumari @jlebon @yuqi-zhang @mfojtik @openshift-bot @knobunc @openshift-merge-robot