-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove redundant kargs assertions #3247
remove redundant kargs assertions #3247
Conversation
The Config Drift Monitor has no interaction with kernel args. This particular case is better covered by the TestKernelArguments test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
commit included in: #3243 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No argument from me on this!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, cheesesashimi, jmarrero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Let's merge this in #3243 so that it will be easier for our bot to cherry-pick in 4.11 |
@cheesesashimi: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Closing since #3243 has been merged with this fix |
Thanks Zack for making the quick fix! |
- What I did
The Config Drift Monitor has no interaction with kernel args. This
particular case is better covered by the TestKernelArguments test.
- How to verify it
Run the TestKernelArguments test
- Description for the changelog
Removed redundant kargs test